From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A017229B18 for ; Fri, 10 Oct 2025 05:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760074004; cv=none; b=NGRlnpg0bKxmjYxa2BQNpUh60+cBEn3Ax0Qp5DcPbRDwtvvBaZFGfoxW7kIV4Pl4580GrUdKcCzmksBlEWBOv8MrEHThRhfPnszF6S78iF31kZvTy862hHwUCtJQxMi9UhAWk6eNuBw3GFoDj85vgcFN5daJqfMFHcDf6TCTSFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760074004; c=relaxed/simple; bh=6ZQGF56icH764Mt7J7YN4sDhWdEqrpnUJtm3mz3jgl4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mvm2aZEQZiNN6+2hw/j299tvq0KomJw8Lek6AA8FGggP5AhvKaibOwZoqjm61H/CcA3twBQP0NQZI+goegpK1VJgBSt1MNT0VDlx9OehZWBCmcCiGqD8Mct3kTrG1CodcpTG8asEQbaHAxnvxx8zBDRq2UaE18LvPrNXQHAH8/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MgL3ugY8; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MgL3ugY8" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b3d50882cc2so309097766b.2 for ; Thu, 09 Oct 2025 22:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760074000; x=1760678800; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=6ZQGF56icH764Mt7J7YN4sDhWdEqrpnUJtm3mz3jgl4=; b=MgL3ugY8xHj/erMK9BoeMUXC6yoxC+IKwdRacc4ftn5VDad3rxLagK3INGsm3I6U88 9Of5j9URkIjVFrMh4hhoaEairr67z80p9T/2BlN5Jb5S4eNToX00kqi3NXDK7Uznem5J OfLi62zaea4nxYK8IM52xlfBgT7d2S35D/p+5JBTNfXaRuIbNlrMMe42r2N5+p8eYrEG 3jFLWqpMjRQzzHMn/bXUfqWrjHc78stP/xh2KsTN87l1YYdf+zO+O7Aw2ctIqHEQsyHC 0WHp+bEwQ0zJipk/xRCUBeO/AsHcnusV7ozDPbb/rNvjFTS9hHwtsCGX05wSLp8tx9DZ hfQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760074000; x=1760678800; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6ZQGF56icH764Mt7J7YN4sDhWdEqrpnUJtm3mz3jgl4=; b=iiebzzyHGHjvztQWHVFMmhhPE4XtJGfVrGPOT0rSQLsik3YOLfOJyuMKi9XTxraTS9 DyIbZKs1IjJ3FdFL3Xju3vI3QVF5v/TwsNXyHsx118giUENcv4g+WLT9a7m3/q6x4imx LcUlOAJ8I3vrSBGRiBkyaaAmgGY12Vxo3dYOoUpYTrndQ8jaKT+gn6QXKm6CcuEf3hWH 0TCrtiHtCUJ+5va0bai1kcu54NPwGxAxebvoXEp8uKVGgaQrGUJANRPaF8Gya3GJ8XO+ Vg/l4LE1a4ibR5iwsvBOVGoGC1Ng4Lhk3scM+z71a14J1oS6B/p86lrT5kRim/NsC9gX CLMw== X-Forwarded-Encrypted: i=1; AJvYcCXZLPGM6OgZrrRSw1t4em/ogs1/6mYof2TFu4O5TpdG6CGEnAovOz5WxfRiKfdKdnFhay+mj19dEg==@vger.kernel.org X-Gm-Message-State: AOJu0YwPpKnc3DkJrrUqjwSV83db9C16nr1/Pw+RHXMVgmfRKe9nEy3T GOJVt6aOx/tYGMw0dpnd/IR4593S2QOXdsBQTqvQvvC5J0ouBTdMnZlkS+3o8bxsymI= X-Gm-Gg: ASbGncvXLe9VJdiiK/4oBaFvsBlk0y/z2J0A8mBpwyTNNSoyQuwWXS3gGw0NtFcnpNT jg7+ZfY92F5qyrTtQCpukPub4w/E3PRG9cE9rxd4cO8Cl7bcRpezCe43HXG3g2qZQJEOp5yuvr5 TSfm2J2Kfl1iyKlblax9w3LDtLIVHtIsKhzhUcwrKfqqJh26Dpyh8dtVADRX4+Cr5tgUqbI751F yZ7J23l/3pFWqN910vESIiJ3IUeJoOPbgd4GpXemN3m+LZTigSQDWYymaV0jq2D6nIbaLAABdyX HVv2REnYO2VdSnW0vhqYH+QtqmWgd8MQbtDZFcFEGp0gwwtt+jzow5XKmUbLGmtG42+eT37wfCV NEINA2Q1kvb12vgKgYHvWUHKTNFqD9Hou4tknArrlyWhSlZ+M X-Google-Smtp-Source: AGHT+IEF98Rap0U5ucjnQVUtn0KSvNbP6eAmxW5/uObKfUgC9D3KfjVTiQLvrdfy3ldcft7mxBgDmQ== X-Received: by 2002:a17:907:fd89:b0:b40:cfe9:ed41 with SMTP id a640c23a62f3a-b50ac0cb1cemr924261166b.34.1760074000382; Thu, 09 Oct 2025 22:26:40 -0700 (PDT) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b55d900cc52sm140260566b.60.2025.10.09.22.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 22:26:39 -0700 (PDT) Message-ID: <4ab0d483175c17b476d2d51923b38b272802f60e.camel@linaro.org> Subject: Re: [PATCH v2 03/10] dt-bindings: soc: samsung: gs101-pmu: allow power domains as children From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Marek Szyprowski Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Fri, 10 Oct 2025 06:26:38 +0100 In-Reply-To: <20251009-gs101-pd-v2-3-3f4a6db2af39@linaro.org> References: <20251009-gs101-pd-v2-0-3f4a6db2af39@linaro.org> <20251009-gs101-pd-v2-3-3f4a6db2af39@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-10-09 at 16:25 +0100, Andr=C3=A9 Draszik wrote: > The power domains are a property of / implemented in the PMU. As such, > they should be modelled as child nodes of the PMU. >=20 > Signed-off-by: Andr=C3=A9 Draszik >=20 > --- > Note: Ideally, the newly added properties (ranges, etc.) should only be > 'required' if "^power-domain@[0-9a-f]+$" exists as a patternProperty, > as they're needed only in that case. As-is, this patch now causes > warnings for existing DTs as they don't specify the new properties (and > they shouldn't need to). Only if DTs are updated to include > power-domains, such an update should also add the new properties. >=20 > I've not been able to come up with the correct schema syntax to achieve > that. dependencies, dependentRequired, and dependentSchemas don't seem > to support patterns. Similarly, > =C2=A0 - if: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 required: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - ... > =C2=A0=C2=A0=C2=A0 then: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 required: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - ... >=20 > doesn't allow patterns in the 'if' block (or I didn't get the syntax > right). > --- > =C2=A0.../bindings/soc/google/google,gs101-pmu.yaml=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 42 +++++++++++++++++++++- > =C2=A01 file changed, 41 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pm= u.yaml > b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml > index 209ee2f80d449c3eec568188898b3c6f7ae0ddd4..d18a351b649c0736662e67bb6= 4de46afa01e399a 100644 > --- a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml > +++ b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml > @@ -27,6 +27,14 @@ properties: > =C2=A0=C2=A0 reg: > =C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 1 > =C2=A0 > +=C2=A0 '#address-cells': > +=C2=A0=C2=A0=C2=A0 const: 1 > + > +=C2=A0 '#size-cells': > +=C2=A0=C2=A0=C2=A0 const: 1 > + > +=C2=A0 ranges: true > + > =C2=A0=C2=A0 reboot-mode: > =C2=A0=C2=A0=C2=A0=C2=A0 $ref: /schemas/power/reset/syscon-reboot-mode.ya= ml > =C2=A0=C2=A0=C2=A0=C2=A0 type: object > @@ -50,18 +58,50 @@ properties: > =C2=A0=C2=A0=C2=A0=C2=A0 description: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Phandle to PMU interrupt generation = interface. > =C2=A0 > +patternProperties: > +=C2=A0 "^power-domain@[0-9a-f]+$": > +=C2=A0=C2=A0=C2=A0 type: object > +=C2=A0=C2=A0=C2=A0 description: Child node describing one power domain w= ithin the PMU > + > +=C2=A0=C2=A0=C2=A0 additionalProperties: true > + > +=C2=A0=C2=A0=C2=A0 properties: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const: google,gs101-pd > + > =C2=A0required: > =C2=A0=C2=A0 - compatible > =C2=A0=C2=A0 - reg > +=C2=A0 - '#address-cells' > +=C2=A0 - '#size-cells' > +=C2=A0 - ranges > =C2=A0=C2=A0 - google,pmu-intr-gen-syscon > =C2=A0 > -unevaluatedProperties: false > +additionalProperties: false Ooops, this line should have been part of patch 02 in the first place. Will fix in next version. Cheers, Andre'