From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Zhang Rui" <rui.zhang@intel.com>,
"Eduardo Valentin" <edubezval@gmail.com>
Cc: "Stefan Wahren" <stefan.wahren@i2se.com>,
"Jon Mason" <jonmason@broadcom.com>,
linux-pm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] thermal: bcm2835: move to the broadcom subdirectory
Date: Mon, 17 Apr 2017 14:19:37 -0700 [thread overview]
Message-ID: <4d01beef-41a4-1a21-5aea-af4c9b698269@gmail.com> (raw)
In-Reply-To: <20170417210416.16426-1-zajec5@gmail.com>
On 04/17/2017 02:04 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> We already have 2 Broadcom drivers and at least 1 more is coming. This
> made us create broadcom subdirectory where bcm2835 should be moves now.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> I'm resending this patch including linux-pm mailing list. Sorry for
> missing it previously.
> ---
What tree is this against?
> drivers/thermal/Kconfig | 8 --------
> drivers/thermal/Makefile | 1 -
> drivers/thermal/broadcom/Kconfig | 8 ++++++++
> drivers/thermal/broadcom/Makefile | 1 +
> drivers/thermal/{ => broadcom}/bcm2835_thermal.c | 0
> 5 files changed, 9 insertions(+), 9 deletions(-)
> rename drivers/thermal/{ => broadcom}/bcm2835_thermal.c (100%)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 6699843918fa..f786ae433032 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -468,12 +468,4 @@ config ZX2967_THERMAL
> the primitive temperature sensor embedded in zx2967 SoCs.
> This sensor generates the real time die temperature.
>
> -config BCM2835_THERMAL
> - tristate "Thermal sensors on bcm2835 SoC"
> - depends on ARCH_BCM2835 || COMPILE_TEST
> - depends on HAS_IOMEM
> - depends on THERMAL_OF
> - help
> - Support for thermal sensors on Broadcom bcm2835 SoCs.
> -
> endif
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index a1e9b8b4e897..e6834061da28 100644
> --- a/drivers/thermal/Makefile
> +++ b/drivers/thermal/Makefile
> @@ -60,4 +60,3 @@ obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
> obj-$(CONFIG_GENERIC_ADC_THERMAL) += thermal-generic-adc.o
> obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o
> -obj-$(CONFIG_BCM2835_THERMAL) += bcm2835_thermal.o
How are we recursing into drivers/thermal/broadcom?
> diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig
> index f0dea8a8e002..ab08af4654ef 100644
> --- a/drivers/thermal/broadcom/Kconfig
> +++ b/drivers/thermal/broadcom/Kconfig
> @@ -1,3 +1,11 @@
> +config BCM2835_THERMAL
> + tristate "Thermal sensors on bcm2835 SoC"
> + depends on ARCH_BCM2835 || COMPILE_TEST
> + depends on HAS_IOMEM
> + depends on THERMAL_OF
> + help
> + Support for thermal sensors on Broadcom bcm2835 SoCs.
> +
Don't we also need a:
source drivers/thermal/broadcom/Kconfig to be placed within
drivers/thermal/Kconfig?
> config BCM_NS_THERMAL
> tristate "Northstar thermal driver"
> depends on ARCH_BCM_IPROC || COMPILE_TEST
> diff --git a/drivers/thermal/broadcom/Makefile b/drivers/thermal/broadcom/Makefile
> index 059df9a0ed69..c6f62e4fd0ee 100644
> --- a/drivers/thermal/broadcom/Makefile
> +++ b/drivers/thermal/broadcom/Makefile
> @@ -1 +1,2 @@
> +obj-$(CONFIG_BCM2835_THERMAL) += bcm2835_thermal.o
> obj-$(CONFIG_BCM_NS_THERMAL) += ns-thermal.o
> diff --git a/drivers/thermal/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
> similarity index 100%
> rename from drivers/thermal/bcm2835_thermal.c
> rename to drivers/thermal/broadcom/bcm2835_thermal.c
>
--
Florian
next prev parent reply other threads:[~2017-04-17 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 21:04 [PATCH] thermal: bcm2835: move to the broadcom subdirectory Rafał Miłecki
2017-04-17 21:19 ` Florian Fainelli [this message]
2017-04-17 21:21 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d01beef-41a4-1a21-5aea-af4c9b698269@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=edubezval@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=rui.zhang@intel.com \
--cc=stefan.wahren@i2se.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox