From: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
To: Huacai Chen <chenhuacai@loongson.cn>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Huacai Chen <chenhuacai@kernel.org>
Cc: loongarch@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Xuerui Wang <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Hongliang Wang <wanghongliang@loongson.cn>,
zhongqiu.han@oss.qualcomm.com
Subject: Re: [PATCH V2 0/5] cpufreq: loongson3: Fix wrong behaviors on multi-node servers
Date: Tue, 1 Sep 2026 16:01:11 +0800 [thread overview]
Message-ID: <4db03770-b410-4298-9e32-d497278e9cfa@oss.qualcomm.com> (raw)
In-Reply-To: <20260828031201.1500767-1-chenhuacai@loongson.cn>
On 8/28/2026 11:11 AM, Huacai Chen wrote:
> Our server productions (e.g. Loongson-3D6000/3E6000) can have multiple
> nodes in one package and SMC mailboxes are also per-node. However, the
> current driver has wrong behaviors on multi-node servers, including: id
> field in smc_message is too narrow, mutex is not per-node, IOCSR read/
> write can only perform on the current node, etc. This series fix all the
> above problems.
>
> V1 -> V2:
> 1. Fix typos and add Fixes tags.
> 2. Fix loongson3_cpufreq_get() return values.
> 3. Use nid_to_addrbase() rather than hard code.
> 4. Guard some code with CONFIG_SMP to avoid build errors.
>
> Hongliang Wang & Huacai Chen (5):
> cpufreq: loongson3: Make this drvier depend on MACH_LOONGSON64
> cpufreq: loongson3: Adjust the width of id and val in smc_message
> cpufreq: loongson3: Replace per-package mutex with per-node
> cpufreq: loongson3: Use global physical CPU ID in get/target callbacks
> cpufreq: loongson3: Replace IOCSR read/write with MMIO ones
>
> Signed-off-by: Hongliang Wang <wanghongliang@loongson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> drivers/cpufreq/Kconfig | 1 +
> drivers/cpufreq/loongson3_cpufreq.c | 72 ++++++++++++++++++++++++-------------
> 2 files changed, 48 insertions(+), 25 deletions(-)
The whole series looks good to me.
Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
> ---
> 2.27.0
>
>
--
Thx and BRs,
Zhongqiu Han
prev parent reply other threads:[~2026-09-01 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 3:11 [PATCH V2 0/5] cpufreq: loongson3: Fix wrong behaviors on multi-node servers Huacai Chen
2026-08-28 3:11 ` [PATCH V2 1/5] cpufreq: loongson3: Make this driver depend on MACH_LOONGSON64 Huacai Chen
2026-08-28 3:11 ` [PATCH V2 2/5] cpufreq: loongson3: Adjust the width of id and val in smc_message Huacai Chen
2026-08-28 3:11 ` [PATCH V2 3/5] cpufreq: loongson3: Replace per-package mutex with per-node Huacai Chen
2026-08-28 3:12 ` [PATCH V2 4/5] cpufreq: loongson3: Use global physical CPU ID in get/target callbacks Huacai Chen
2026-08-28 3:12 ` [PATCH V2 5/5] cpufreq: loongson3: Replace IOCSR read/write with MMIO ones Huacai Chen
2026-09-01 8:01 ` Zhongqiu Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4db03770-b410-4298-9e32-d497278e9cfa@oss.qualcomm.com \
--to=zhongqiu.han@oss.qualcomm.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wanghongliang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox