From: Shuah Khan <skhan@linuxfoundation.org>
To: Min-Hua Chen <minhuadotchen@gmail.com>,
Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>
Cc: "John B . Wyatt IV" <sageofredondo@gmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 for-next] pm: cpupower: rename raw_pylibcpupower.i
Date: Fri, 13 Sep 2024 14:32:39 -0600 [thread overview]
Message-ID: <4e064b13-2473-4a65-a0a1-94f0edb36432@linuxfoundation.org> (raw)
In-Reply-To: <20240913201705.7764-1-minhuadotchen@gmail.com>
On 9/13/24 14:17, Min-Hua Chen wrote:
> The raw_pylibcpupower.i is removed unexpectedly after 'make mrproper'
>
> We can reproduce the error by performing the following steps:
> cd linux-next
> make mrproper
> cd tools/power/cpupower/bindings/python
> make
>
> We will get an error message:
> make: *** No rule to make target 'raw_pylibcpupower.i', needed by 'raw_pylibcpupower_wrap.c'. Stop.
>
> The root cause:
>
> The *.i files are already used for pre-processor output files and
> the kernel removes all the *.i files by 'make mrproper'.
>
> That explains why the raw_pylibcpupower.i is removed by 'make mrproper'.
>
> To fix it, Follow John's suggestion to rename raw_pylibcpupower.i to
> raw_pylibcpupower.swg.
>
> See:
> https://www.swig.org/Doc4.2/SWIG.html
>
> Reviewed-by: John B. Wyatt IV <jwyatt@redhat.com>
> Reviewed-by: John B. Wyatt IV <sageofredondo@gmail.com>
> Tested-by: John B. Wyatt IV <jwyatt@redhat.com>
> Tested-by: John B. Wyatt IV <sageofredondo@gmail.com>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
>
> ---
>
> change since v1:
> build a non-frc patch
> change since v2:
> follow the document to rename *.if to *.swg
>
Thank you Min for finding the problem and working with us
to fix it.
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower
Please note that this will be sent to PM maintainer in my next pull
request. This might be after the merge window.
thanks,
-- Shuah
prev parent reply other threads:[~2024-09-13 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 20:17 [PATCH v3 for-next] pm: cpupower: rename raw_pylibcpupower.i Min-Hua Chen
2024-09-13 20:32 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e064b13-2473-4a65-a0a1-94f0edb36432@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=minhuadotchen@gmail.com \
--cc=sageofredondo@gmail.com \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox