From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6A6E40A934 for ; Thu, 6 Aug 2026 10:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786013609; cv=none; b=AEmX4D2tqq/TuYTJ5K2qyBu0CpGxYtDJjRW1nYmRLtmvbE5YuRZPn+rHBHBoOK95cSxtTX8hMY1VpZu7L2L/haxgqdoOflZdwMCnZ1+OneCSfUlBqsTY7piuPFBj2O6aZn5a6GNy1BIHvvrRv9rMwis/euL04TggR3pmdVUdUkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786013609; c=relaxed/simple; bh=dJPIcsDZlDMAfg6zUysI1OwcH+C+3jNCyN4Fa+Z/3cE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cEnbk/gst0/R7GOq3s/HAT2ylG/8Zk3t3RKH5Yoh2dUUZ9if+yS2UbinKDtxCtRCT+KPrxF0qPJlWaA+Kcbhy6dNNJSu3zS2Dd7Z+5h5qZis5WeWy6PjICKPcFZFJIoRfYntdiiHyM7P5K0Wv03n7uhFvQElKMJsgRkgJzrBY7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TpZxN6TF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SOsejs3B; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TpZxN6TF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SOsejs3B" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6769neRX1876452 for ; Thu, 6 Aug 2026 10:53:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mqTT4OdC+eo+D0Ndmyh5RHA/+pCdGGJQeQVezw4oxEM=; b=TpZxN6TFkXbMCi+m 4hBcxBQotVcxhl1AD+K6QB6nZgmMe4v6RhPZh1yd2QQgqUjkZSPVAT7HNW+KKviS 8VNJDKRMjmWpiJ/zMxSnxbdoCcp+TBPEV4n25Bk1UhfTjmaYKRUh4PHRAoMsqZ/U yQqksRYN1BS8bJqLeoVDzMVbPV+bNgOiBYa3i5PbDC5gNRtbeLnhPe+5NO6WkqlU vVLbEInMFyw9sLvnhICiHbOr3C1L1VITUwMVQ91W7cMySVCRD3oW5sxaaskz1uAm wrj8qTYeiNdkB8ohk0d7EtIrueNawBYue3dgfMwARmEdfQBrBO5UhjGheiLPDDJV xqeUeQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fvjuchnbc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Aug 2026 10:53:25 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84e048a801dso2825999b3a.3 for ; Thu, 06 Aug 2026 03:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786013605; x=1786618405; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mqTT4OdC+eo+D0Ndmyh5RHA/+pCdGGJQeQVezw4oxEM=; b=SOsejs3BkCA4bp4bak8qaKTL3raAayl18wXunc0ul4Baoh0gNXriR73iDlOaYSwYPe ugZciG0X0eD6k358nbhjZlE8a3WNx0/VnRWEO5ADOFBZgapsXjeBL7q4UuhdzeRyrL4F jXuaUk0TVV4jOt7z4We8nOPpKJXl4IUGyyvKpjb+rExOt4OhVtgrtyYs0b078oY6gnOv nmm161FrnKZ+YvaDraMZbDNjZve+gjRgro62oh30JeDMCrL0Lt+ssPAAkKs3pJylkQ39 9UXRi8xw0Ng2YKndb0olRpHLQKwjLt/2spfscDIjjGTHBr4Ta4GLy0ItG96SVS/dAzx9 j4qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786013605; x=1786618405; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mqTT4OdC+eo+D0Ndmyh5RHA/+pCdGGJQeQVezw4oxEM=; b=ijJdmgKn0+FtB20QJ6+LA308fQlX55Ivw7SaCOpmpTZPeEXQOf7UMb1fXcrZBJX0TF 3u82/IHWKwvv2YXVZi0dQgC1EDdAdRkJ3qx32oG8YIOA7h4hMopPb4/6IM3FG4gevXoZ MScPz4zxe1ipXic+oQFOre/pwBDLO/6hkupTfW+IZEYRDwHBLyUQMzggSv7o2C+cvZW6 kuk8WKFGJvfZpd0GxcfHw0xqhfGglEdUWZrEfb7kIm9c3d/L6CDaw6+ODv/UcQB4eQzt ruahFB3+guGvAnaAaAzPcImp5TbfmoFTMsMXz5bDe8AU83TgKYMYvDbHOg1twswrBEcD 1oeA== X-Forwarded-Encrypted: i=1; AHgh+Rq57zuRWJTI/HsSa6WYZ45vfQubc/7JRkYglX2/EiC6W1E6rEBPf/Z+XMNU1e1M3Hjvn7R0yZFKwA==@vger.kernel.org X-Gm-Message-State: AOJu0YygwoJk4rQpb9O01AgTeXD7mweOpofEGacCsJ+h2WA0OCMM0SbE 7UafHKPmlzMnlJe788mKddBA9gOpH3fLFUsm3LvkBO0WEYwxPaku3dbuGbr08KwnsnhN//cLItR fFIOCUewdZOPJB2L+ZGq2o/SOOUiG9AItM236JMSGGmHfb3CcsyV7gH59JGELzA== X-Gm-Gg: AR+sD1090dMNWrurg7n4KHiwRCo4bghDGmKJC96lBd44AsrvpTkW78m0ck+QGEWnWY/ bt3qpLdc3RH85BE+Ps8EyHnQtk+K5H7/J8HBSxSnSplZvpRO70VERWEZQ03m2C3oJV0Z2ciwygn 5Ib3godhPK48iGmtZawIUZKHB34a1Ze0z1OCSEuGpU5r/qO88IG2KOwFfvIVsWGLC3Axhkr2yv4 eIiARj/Of/c13awKhJtzbINV95byPUnf+dkLAR/nCWQUT/lQQlbonNAVv/idkMK7c+APbvtoIiT 2fXkbAUCpDnD4mYhN0i7eeazUSBoDT70npK0joT5Q7YetFYnzXKQjvB2gZv2xN0XjoNrJ5bST8F 6ChlY7flq2lRj4BMeU5DpHJnZwlknsBiB X-Received: by 2002:a05:6a00:4293:b0:84a:6540:3389 with SMTP id d2e1a72fcca58-84f2dfc53e4mr16136570b3a.10.1786013604718; Thu, 06 Aug 2026 03:53:24 -0700 (PDT) X-Received: by 2002:a05:6a00:4293:b0:84a:6540:3389 with SMTP id d2e1a72fcca58-84f2dfc53e4mr16136504b3a.10.1786013604208; Thu, 06 Aug 2026 03:53:24 -0700 (PDT) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45389e5bsm1173338b3a.1.2026.08.06.03.53.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 03:53:23 -0700 (PDT) Message-ID: <4e25b74c-baea-4283-9730-7313162284b5@oss.qualcomm.com> Date: Thu, 6 Aug 2026 16:23:15 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen4 ADC To: Krzysztof Kozlowski Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Bjorn Andersson , Konrad Dybcio , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , Anjelique Melendez , Manaf Meethalavalappu Pallikunhi , Priyansh Jain References: <20260731-pmic5_gen4_adc-v1-0-9c49b2eea6f9@oss.qualcomm.com> <20260731-pmic5_gen4_adc-v1-1-9c49b2eea6f9@oss.qualcomm.com> <20260804-marvellous-crayfish-of-recreation-d06401@quoll> Content-Language: en-US From: Jishnu Prakash In-Reply-To: <20260804-marvellous-crayfish-of-recreation-d06401@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDA4NSBTYWx0ZWRfX/o9NFi/oOb2w hJDJ/1SENzl7iLLEn2VdqfEq+qEkzx86u4peOOiDB9M+ez5MOrKVFDFhAmPfoLgXKCRKYcMeC1H 3IYGXYkHVsh5eW986U3EeQ1mV4+HrKE= X-Proofpoint-GUID: JrgzYzrkDYeBLOeYNBbwvSreOd5KhIHw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDA4NSBTYWx0ZWRfX83gH3RMuwx93 wXYJJ2Ngrrje8SFDZn6V1cD1IweRmMR7nzFbEgPAsfN9ULscs6bIxsSrgWLnO2TtZqqmNSzp9X8 9WZi83j+HqGsfKBjW529S+UpbKauFm1PKC2Ce9AgHX5cQolwTJt1Lc/ZhdNQB9Q+5+v3FFdaS76 J2SgCD3go49CDrrAA2Sm1MmPpE2XeDSqBe+zHFu8lPLHTz8INsmoKu6Zj5PADGLl/LMm9MBCmTB Suip/9QZWyN9Kd5bEaMLVq8PRZzrDkBAVsGeQtmWRnUWQ+cpxl+WCHS/SCg4w8QSEbvu1aj+xnE Z5mIauUaJIHUx/sxXFKbVxuzSDGHW6K0dyciW6EBj9oRWc/C8bJw+w80Vy8erhd4QvbDU8YyIqx BtujHlnXg7YXEy5OaQpX3ajHB6TQeFe5PWD50pHpCng8KgNsx2yWNHjCPfM9rPm273FrSoo2NT1 Rr0QhveOWu4wxgUTGHQ== X-Authority-Analysis: v=2.4 cv=Mo1iLWae c=1 sm=1 tr=0 ts=6a7467a5 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=he8iogTWBVq0M3DZNvYA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: JrgzYzrkDYeBLOeYNBbwvSreOd5KhIHw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_06,2026-08-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 adultscore=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608060085 Hi Krzysztof, On 8/4/2026 1:50 PM, Krzysztof Kozlowski wrote: > On Fri, Jul 31, 2026 at 11:36:14PM +0530, Jishnu Prakash wrote: >> PMIC5 Gen4 ADC is similar to PMIC5 Gen3 ADC, with several changes made for >> improved performance, mostly at the hardware level. The main differences are >> increased ratiometric conversion resolution (from 14 bits to 16 bits) and >> increased bit field width for PMIC SID (to allow communication with an >> increased number of PMICs, supported on latest SoCs). >> >> Signed-off-by: Jishnu Prakash >> --- >> .../bindings/iio/adc/qcom,spmi-adc5-gen3.yaml | 47 +++++++++++++++++++++- >> 1 file changed, 46 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml >> index 149f4af8f4b8..e79ddc2acca0 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml >> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml >> @@ -21,9 +21,14 @@ description: | >> All boards using a particular (SOC + master PMIC) combination will have the >> same number of ADC SDAMs supported on that PMIC. >> >> + PMIC5 Gen4 ADC is similar to Gen3 ADC, with some differences such as >> + improved ratiometric conversion resolution. >> + >> properties: >> compatible: >> - const: qcom,spmi-adc5-gen3 >> + enum: >> + - qcom,spmi-adc5-gen3 >> + - qcom,spmi-adc5-gen4 >> >> reg: >> items: >> @@ -83,6 +88,46 @@ patternProperties: >> This property indicates ADC_TM monitoring is done on this channel. >> type: boolean >> >> + qcom,adc5-gen4: >> + description: >> + Indicates channel is of type ADC5 Gen4. This may be needed in cases where the >> + master PMIC has an ADC peripheral of type Gen3, but some of the other PMICs it >> + communicates with have ADC peripherals of type Gen4, so channels of those PMICs >> + need to be marked as Gen4 to ensure their conversions are handled correctly. >> + type: boolean > > It is implied by the compatibles, in this case the peripheral > compatible. This property is needed in cases where a Gen3 master PMIC has Gen4 channels under it. The main point to keep in mind for Gen3/Gen4 ADC is that the compatible describes the ADC peripheral on the master PMIC, but the master PMIC's ADC communicates with ADCs on other PMICs, which may not always be of the same generation. Under the master PMIC's ADC DT node, we have ADC channel nodes from all the PMICs it communicates with. For example, SM8750 has the following 8 PMICs, having ADC channels: PMK8550 (Gen3 master PMIC) PM8550 PM8550vs (2 instances) PM8550ve (3 instances) PMIH0108 ADCs on the first 7 PMICs are of type Gen3, but PMIH0108 has Gen4 ADC. So ADC channels of PMIH0108 exposed under the PMK8550 ADC peripheral need to have the "qcom,adc5-gen4" property to indicate they are of a different generation and may need a different conversion formula. Similarly, on some variants of the upcoming mobile platform Maili, we have the opposite case (master PMIC has Gen4 ADC, one of the other PMICs has Gen3 ADC), so we would also need the "qcom,adc5-gen3" property for some platforms. I'll add a description for these properties too in the commit message, hope it helps. Thanks, Jishnu > > Best regards, > Krzysztof >