From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 42F3419E; Tue, 21 Nov 2023 13:08:25 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C09D8168F; Tue, 21 Nov 2023 13:09:11 -0800 (PST) Received: from [10.57.3.233] (unknown [10.57.3.233]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5E7C03F7F4; Tue, 21 Nov 2023 13:08:22 -0800 (PST) Message-ID: <4e3b7661-7233-4142-a785-406ec384d90a@arm.com> Date: Tue, 21 Nov 2023 21:09:21 +0000 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 9/9] thermal: exynos: use set_trips Content-Language: en-US To: Mateusz Majewski Cc: Bartlomiej Zolnierkiewicz , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , Liam Girdwood , Mark Brown , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231120145049.310509-1-m.majewski2@samsung.com> <20231120145049.310509-10-m.majewski2@samsung.com> From: Lukasz Luba In-Reply-To: <20231120145049.310509-10-m.majewski2@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/20/23 14:50, Mateusz Majewski wrote: > Currently, each trip point defined in the device tree corresponds to a > single hardware interrupt. This commit instead switches to using two > hardware interrupts, whose values are set dynamically using the > set_trips callback. Additionally, the critical temperature threshold is > handled specifically. > > Setting interrupts in this way also fixes a long-standing lockdep > warning, which was caused by calling thermal_zone_get_trips with our > lock being held. Do note that this requires TMU initialization to be > split into two parts, as done by the parent commit: parts of the > initialization call into the thermal_zone_device structure and so must > be done after its registration, but the initialization is also > responsible for setting up calibration, which must be done before > thermal_zone_device registration, which will call set_trips for the > first time; if the calibration is not done in time, the interrupt values > will be silently wrong! > > Signed-off-by: Mateusz Majewski > --- > v4 -> v5: Simplified Exynos 7 code, used the correct register offsets > for Exynos 7 and refactored some common register-setting code. > v2 -> v3: Fixed formatting of some comments. > v1 -> v2: We take clocks into account; anything that sets temperature > thresholds needs clk. > > drivers/thermal/samsung/exynos_tmu.c | 393 ++++++++++++++------------- > 1 file changed, 209 insertions(+), 184 deletions(-) The code LGTM and I like the idea of dynamically configured IRQs for trips. Reviewed-by: Lukasz Luba Regards, Lukasz