From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 167E0439F6F for ; Mon, 17 Aug 2026 13:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974190; cv=none; b=SDbkKb8PcG/A6CgDceVM/7m9cr/nLObk/D70kpmEUKJLKnB/5ES8TqvLFExSeu4za5naxqknmJ01gJF2ZqiGFrt8Cj8sgLSzsoRXgF8bvobjNxF6iInbmXFvnSAYsUB3dMd0rfzbbYwuBPelbNuZL1hwHhJdMiIjBd+G7KVIEm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974190; c=relaxed/simple; bh=qqLvjb2Elb3FkUURTZ8DaEFjPYAiQE9nj5Xz5BxcjoA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u7/fkDGAn6vL7yCexLkFiRX7BbjtM3JSqD8qMH2l0qRTo9Tt6JmFzVWO0hidabguKef5FCfFslZNzSpgJDn2DZCDNgvoW8fjdnFtZsEPH5ksQV/l6L8QFpD9YGfmrzThozpdwPijOXpvldbsZ7hKl8oChFLoXcxAJeaCfPtpOQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aXp1MmBt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gTO1yiyh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aXp1MmBt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gTO1yiyh" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HD61Vw2329828 for ; Mon, 17 Aug 2026 13:43:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FUi1Ed4tbVFVG10HnIR5+E8xIvkprA3oG5hrzoj+z/M=; b=aXp1MmBtty1BQMei PbRVOkhD3g8tb2bRrp9KrkuIaxeEg2qxHuZA66DnRlM8cyrEdyJHVsyVfdXbLk4l WE9kTc53n5tuUZkEuqie25QBeLkxIPPpeCl3aVrrEKYeA+X2rSbWFELSci5VH/ce 14sKa565PKv3DUN1EsWC881P+fHM6nFXvGxcNm/Od/sHksRHOX6T7jZwVaqC0kfe j63F0xvREL/e6u/PCxnY6EnNvWkF+Wpl3JW6/72r2f0tktHg2PBt8c0tMpFdNydA Efq4tTtNfOUVG7E7iPXihypiwKKqZjg/Gxdg5rz501LpRNDJPHEAceugz2P1u+F0 8xJrKw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3vghsvrp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 13:43:07 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8f39a46efd9so43733106d6.1 for ; Mon, 17 Aug 2026 06:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786974187; x=1787578987; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FUi1Ed4tbVFVG10HnIR5+E8xIvkprA3oG5hrzoj+z/M=; b=gTO1yiyhQitj4WdQMbgAjWCAtmyZKfwlscEbGAMVVddT3upXi7N1nE89Bsd6pUNzw7 bsSkx5/Dd6xp6FGzOg2IvEpD1JqsS1Z/lS4U6mZgatuMvYR/GSPyQQDla+A/ZX+qVaX9 j8dUnnKhbyi3WreNKPFOXw9WCAeFYTd8ua3IeX/mGJT4ZlZxifJXZfhlteVcLIprDA8V 65DdIlheMf9MChuFYiLENaroAf+r0P9wZiMUBAFVUwLBqmheGCW/s6H6gL7zCOXQXe96 sRjU9qf0UbX2L5rX7DP0dM0aq8pQ9WRI0pRA5bXUW6AurGIaTLumXa/8W75+knoD8FKg fyVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786974187; x=1787578987; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FUi1Ed4tbVFVG10HnIR5+E8xIvkprA3oG5hrzoj+z/M=; b=PoVmw7VC/+u6NO70a/LoJtRlSmr8hXPg8qX3DiMgM/7+QdA+Wv0vZdHLTzdU20WTjT 9h8FzFyMgqPqP5IBKfuMTTd543qTzQUrXGvyOcLMlHH8TM83XLtNJW9BbGYWm3OGRmc9 3Jk8wIutGUob6vp6YeUTLyhY5CiGYmAwSrGgag9Mb6UemsHQgLxZ8lZeonYaFjevXlec +uvVr89iuKscPutqdLKErqS6M6vzjsbZGPDFKPc0I1e/bQdhS7EtK8Mk4u4ThlCIUUFA pzbhSEuCAAg5oJlZUqb9lh1FKqQCFzgaa5cPAPMjRRiGFzL0shzbPyYn1Lib2nrBTTp5 Y17Q== X-Forwarded-Encrypted: i=1; AHgh+RrVqsd0Besg+VJ3S9nxP2XcK4suMtLbbnq8i6CG7UCopTCYk0fISIRET60CxTeNNLa/oqCQ6/RkUA==@vger.kernel.org X-Gm-Message-State: AOJu0YwfHFyOf55Eg6kNdV+Nk/hFJ1ChJ0p90X4kAQ9719Dylz8yICjy GtodkqRoRlv5OIgxRwDn0LazYLKiTU/D0Qb7JydCb0eNBYeGPm3tuzG1/X9csU+Czfv2IUuKhJd v9o8M3Cg7jyxTPFEePjyPUEVJNQxpS3+EiTi9CIG8LA4tj0fCiqpnBq/wN4yEdg== X-Gm-Gg: AR+sD10YTDR2i3WsE4iU0YB5N7gyYgPRAPp8Oxbb8Pah0g+6plCu+15jL6y9GRtp4oM 079DtFLKyBjbIIDEL61n9pup/r8T/SD8ga/4CuI6M9CFVlif0yQKqDaHqWuSj2tifkrkWafuIoB gs166ydAJAATRMIT0XUWvAl8NPicKvv3i9aRncMydbU6B8Lf1r5XH5KmYi3b5Q2que6jTMMqujF ShHOuBuT2d2NsYtiEBq8o1bS59IKnzM8UitpJgo9HbGtn50T0UY6jhUPlTR65UKX/Ouk34uls1j ZZDTpXjR6MbtUTBMwpmRhVyea6YGnHkFSU+biDDzAyN3h+0HNkRZBfxNrUtYb9wbTBEsZgkX8NW jTWnTHNkAsVC7dEYWOCCfQUPKVA5zR4xx X-Received: by 2002:a05:6214:da5:b0:908:488b:14f with SMTP id 6a1803df08f44-90a809cfdb6mr331432876d6.5.1786974187208; Mon, 17 Aug 2026 06:43:07 -0700 (PDT) X-Received: by 2002:a05:6214:da5:b0:908:488b:14f with SMTP id 6a1803df08f44-90a809cfdb6mr331432306d6.5.1786974186747; Mon, 17 Aug 2026 06:43:06 -0700 (PDT) Received: from [192.168.1.6] ([122.171.16.103]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c45976942sm9108656d6.42.2026.08.17.06.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 06:43:06 -0700 (PDT) Message-ID: <4e7a398b-e75c-4dca-8380-440ca7cb22c6@oss.qualcomm.com> Date: Mon, 17 Aug 2026 19:12:55 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/15] pinctrl: qcom: Add Kuno pinctrl driver To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Michael Turquette , Stephen Boyd , Brian Masney , Taniya Das , Georgi Djakov , Bartosz Golaszewski , Linus Walleij , Thomas Gleixner , Radu Rendec , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260814-kuno-soc-support-v2-0-3079794f0f73@oss.qualcomm.com> <20260814-kuno-soc-support-v2-9-3079794f0f73@oss.qualcomm.com> Content-Language: en-US From: Hardeep Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=P9gKQCAu c=1 sm=1 tr=0 ts=6a830fec cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=deEPgmDcWg2uv8mOPSE3jA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=xskrFx3CC3nc2tfbzagA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDEwNSBTYWx0ZWRfX7qvp/L9H5oSZ QuNnLGc0RUMsa85F6G36ze4oBrjh9/5Y01cztM4Hx3IwiUQoJJRSd3ioeFUnngZhUwIwfwluNVt 20qbMiYgj7mrij8ckoN6LM9U8HMj2fQ= X-Proofpoint-ORIG-GUID: q_jeO9pQSbwFPuQBdkfoIdu-RUpL3akE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDEwNSBTYWx0ZWRfX5Mqcj2w6L68n Zb5hGo4JJtV/W4vLjvg781b+60rpmhjyoohgB5KcjEKRXinx5WdawFiWc5CC1neXTKOR+tle9Tj VWKbFxuXG8kOmG//MnnAfs+rKiEW82wVRqB+hxvZdvAO04xkz5zdTQFzw4PIl6EbDSpQytYX2oS Q9sy595vC1prqhV7Wlqe0rxHN6gsB1GjBDP3l1AWbcfxDFDrqTlqu2RAe45d81qD1paK73ZALb9 ot81dbS5W5r3eNrC8LdIgZWlhoIIlvsdvFX3jwKAgisGiGVVKnkp/9UQXYZsEN6Jqywt+duwzUF E1I2vsK3pu9/i5BepDXmX6JRn7BlN/8LkrCly2o6KFLdm1aFBcUWb/J8tr/xwxw4/MYjgl+pPZc 4MtL9Zc3peUvOeUyyqzsZhFHg8SSHKRtr3IpO8/6VmesmzDXsLk/BLFVGAhuNdvbFVuB6OROhj2 3+VgQdGq7N09p/aCsXA== X-Proofpoint-GUID: q_jeO9pQSbwFPuQBdkfoIdu-RUpL3akE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170105 On 8/17/2026 6:54 PM, Konrad Dybcio wrote: > On 8/14/26 9:31 AM, Hardeep Sharma wrote: >> Add the TLMM pinctrl driver for the Qualcomm Kuno platform, supporting >> 110 GPIOs and their pin multiplexing, pin configuration and gpiolib >> interface through the common pinctrl-msm driver. >> >> Signed-off-by: Hardeep Sharma >> --- > [...] > >> + [65] = PINGROUP(65, qup0_se1, qdss_cti_trig1, qdss_cti_trig1, NA, NA, NA, NA, NA, NA), >> + [66] = PINGROUP(66, qup0_se1, qdss_cti_trig1, qdss_cti_trig1, NA, NA, NA, NA, NA, NA), > Function3 can't be selected because of repeating names > > In qdss_cti_trig1_groups, you have qdss_cti_trig1 specified twice. > Perhaps there was a longer name that got truncated? > > Konrad Thanks Konrad for review. It's a real qdss_cti_trig1 line - the in/out mirror partner of funcsel 2:    GPIO65: fsel2 = qdss_cti_trig1_in_mirb, fsel3 = qdss_cti_trig1_out_mire    GPIO66: fsel2 = qdss_cti_trig1_out_mirb, fsel3 = qdss_cti_trig1_in_mire Both map to the same name because the driver uses one coarse "qdss_cti_trig1" for the in/out mirror variants. Listing the function on both funcsels is the normal sdx convention for these mirror pairs - the in-tree drivers do it, including the same pins on sdx65:    - sdx55 [16][17][22][23][54][55][94][95] → in pinctrl-sdx55.c, pins 16, 17, 22, 23, 54, 55, 94, 95 each repeat qdss_cti at two funcsels.    - sdx65 [65]/[66] → in pinctrl-sdx65.c, pins 65 and 66 do it —    - sdx75 [16][52][53][56][57][78][79] → in pinctrl-sdx75.c, those pins do it. Only funcsel 2 is selectable from DT (first-match), which is expected and matches those drivers. Best Wishes Hardeep Sharma