From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
Zhang Rui <rui.zhang@intel.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] thermal/drivers/imx: Use the thermal framework for the trip point
Date: Thu, 9 Mar 2023 09:52:48 +0100 [thread overview]
Message-ID: <4e8235b8-9c2d-69e2-a965-b0787d016ef2@linaro.org> (raw)
In-Reply-To: <CAOMZO5CoYi2MpVLBqoKh7g9Dhjq77KfNy3QQNi2AawjGTrFZpw@mail.gmail.com>
On 09/03/2023 02:11, Fabio Estevam wrote:
> Hi Daniel,
>
> On Wed, Mar 8, 2023 at 6:48 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
>> /* do not allow changing critical threshold */
>> - if (trip == IMX_TRIP_CRITICAL)
>> + if (trip.type == THERMAL_TRIP_CRITICAL)
>> return -EPERM;
>> -
>> +
>
> Unrelated change?
The 'trip' is used as an index and it is checked against
IMX_TRIP_CRITICAL which is a index in the array also. We replace that
with the real type of trip point regardless its id.
But the extra line is a tab which was inserted, I will fix it.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2023-03-09 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 21:48 [PATCH 1/2] thermal/drivers/imx: Remove get_trip_temp ops Daniel Lezcano
2023-03-08 21:48 ` [PATCH 2/2] thermal/drivers/imx: Use the thermal framework for the trip point Daniel Lezcano
2023-03-09 1:11 ` Fabio Estevam
2023-03-09 8:52 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e8235b8-9c2d-69e2-a965-b0787d016ef2@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox