From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Lu Subject: Re: [PATCH v8 05/11] libata-eh: allow defer in ata_exec_internal Date: Thu, 01 Nov 2012 10:35:10 +0800 Message-ID: <5091DFDE.1060904@intel.com> References: <1351501298-3716-1-git-send-email-aaron.lu@intel.com> <1351501298-3716-6-git-send-email-aaron.lu@intel.com> <20121029152051.GK5171@htj.dyndns.org> <508F42C0.8070807@intel.com> <20121030030144.GG4066@htj.dyndns.org> <508F44E1.3000801@intel.com> <20121031215213.GD2945@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com ([143.182.124.21]:6631 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785Ab2KACfR (ORCPT ); Wed, 31 Oct 2012 22:35:17 -0400 In-Reply-To: <20121031215213.GD2945@htj.dyndns.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , "Rafael J. Wysocki" , James Bottomley , Alan Stern , Oliver Neukum , Jeff Wu , Aaron Lu , Shane Huang , linux-ide@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org On 11/01/2012 05:52 AM, Tejun Heo wrote: > Hello, > > On Tue, Oct 30, 2012 at 11:09:21AM +0800, Aaron Lu wrote: >> I'm not aware of a place to store such ODD specific information when >> probing the device. > > You can always add some fields. :) OK. My concern is that, such information is only useful to ZPODD capable device+platforms, so checking this loading mechanism thing for all ATAPI devices during probe time doesn't seem a good idea. > >> I'm currently storing the loading mech type in structure zpodd, which >> gets created after the corresponding SCSI device gets created in >> ata_scsi_scan_host, so at the probe time, the zpodd structure does not >> exist yet. And the reason I create the zpodd sturcture this late is >> that, it is only created when the ODD together the platform is ZPODD >> capable, and to find out if this platform is ZPODD capbale, ACPI binding >> has to occur first, and ACPI binding happens when SCSI device is added >> to the device tree. > > Hmm... I see. Which ACPI binding is it? The ATA ACPI binding happens > during probing. It's a different one, I presume? Since commit 6b66d95895c149cbc04d4fac5a2f5477c543a8ae: libata: bind the Linux device tree to the ACPI device tree ACPI binding happens when SCSI devices are added to the device tree. The ata port/device software structure does not have a acpi_handle field anymore. Thanks, Aaron