linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [RFC] Suspend/resume without VT switches
Date: Fri, 02 Nov 2012 17:22:09 -0700	[thread overview]
Message-ID: <509463B1.8070108@virtuousgeek.org> (raw)
In-Reply-To: <2324361.keTRK1rkYL@vostro.rjw.lan>

On 11/2/2012 4:38 PM, Rafael J. Wysocki wrote:
> On Friday, November 02, 2012 04:29:37 PM Jesse Barnes wrote:
>> On Fri, 02 Nov 2012 22:51:07 +0100
>> "Rafael J. Wysocki"<rjw@sisk.pl>  wrote:
>>
>>> On Friday, November 02, 2012 02:43:39 PM Jesse Barnes wrote:
>>>> I've lightly tested this with X and it definitely makes my
>>>> suspend/resume sequence a bit prettier.  It should speed things up
>>>> trivally as well, but most of those gains come from other changes to the
>>>> i915 driver (posted earlier to intel-gfx).
>>>>
>>>> Any thoughts?
>>>
>>> I like the idea.
>>>
>>>> I suspect we'll have to be more defensive about the
>>>> resume configuration in case the BIOS did something weird, but overall I
>>>> think we should be able to do this one way or another.
>>>
>>> Perhaps patch [1/2] should be [2/2] and vice versa? :-)
>>
>> But then it wouldn't compile?  I added the variable first, defaulting
>> to the current behavior, then made i915 support it and set the variable
>> to false there...  At least, that's what I intended to do.
>
> OK
>
> So what happens if there are multiple graphics adapters in the system?
> Including such that aren't handled by i915?  pm_vt_switch is global, so isn't
> there any problem with that?

Yeah I guess it depends on configuration.  Maybe only the driver that's 
currently driving the VT should be able to set this, then clear it if 
it's no longer in charge?  Not sure how to do that yet (ugg means I get 
to dig into the console layer again...)

Thanks,
Jesse


      reply	other threads:[~2012-11-03  0:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1351892621-4840-1-git-send-email-jbarnes@virtuousgeek.org>
     [not found] ` <7608326.fQBj17U8Wv@vostro.rjw.lan>
     [not found]   ` <20121102162937.1ec88cf1@jbarnes-desktop>
2012-11-02 23:38     ` [RFC] Suspend/resume without VT switches Rafael J. Wysocki
2012-11-03  0:22       ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509463B1.8070108@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).