From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Julius Werner <jwerner@chromium.org>,
Francesco Lavra <francescolavra.fl@gmail.com>,
linux-pm@vger.kernel.org,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>,
Trinabh Gupta <g.trinabh@gmail.com>,
Lists Linaro-dev <linaro-dev@lists.linaro.org>,
len.brown@intel.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Sameer Nanda <snanda@chromium.org>
Subject: Re: [PATCH] cpuidle - remove the power_specified field in the driver
Date: Thu, 13 Dec 2012 08:30:27 +0100 [thread overview]
Message-ID: <50C98413.5050707@linaro.org> (raw)
In-Reply-To: <2077776.UzqC1zVIVr@vostro.rjw.lan>
On 12/12/2012 11:42 PM, Rafael J. Wysocki wrote:
> On Wednesday, December 12, 2012 09:00:53 PM Daniel Lezcano wrote:
>> On 12/12/2012 07:50 PM, Julius Werner wrote:
>>> Thanks again for making this happen, Daniel. I like this version,
>>> except for the small nitpick that I still think it would make sense to
>>> also turn the loop in menu.c around. How about something like this:
>>>
>>> for (i = drv->state_count - 1; i >= CPUIDLE_DRIVER_STATE_START; i++) {
>>> struct cpuidle_state *s = &drv->states[i];
>>> if (!s->disable && s->exit_latency <= latency_req &&
>>> s->target_residency <= data->predicted_us &&
>>> s->exit_latency * multiplier <= data->predicted_us) {
>>> data->last_state_idx = i;
>>> data->exit_us = s->exit_latency;
>>> break;
>>> }
>>> }
>>
>> Actually I was planning to do that in a separate patch.
>
> Can you submit that second patch too, please, so that people don't have to
> wonder?
Sure.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2012-12-13 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 15:23 [PATCH] cpuidle - remove the power_specified field in the driver Daniel Lezcano
2012-12-12 18:50 ` Julius Werner
2012-12-12 20:00 ` Daniel Lezcano
2012-12-12 22:42 ` Rafael J. Wysocki
2012-12-13 7:30 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C98413.5050707@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=deepthi@linux.vnet.ibm.com \
--cc=francescolavra.fl@gmail.com \
--cc=g.trinabh@gmail.com \
--cc=jwerner@chromium.org \
--cc=len.brown@intel.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=snanda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).