Re: [PATCH 0/4] davinci: cpuidle - some cleanups

[Len Brown <lenb@kernel.org>]

On 02/01/2013 08:48 AM, Daniel Lezcano wrote:
> This patchset does some cleanup. It could have been folded in a single
> patch but the review would have been less clean than splitting it into
> small and trivial patches.
> 
> The main purpose of this patch is to remove the usage of the driver_data
> field from the state_usage structure. Len Brown is doing this cleanup in
> the intel_idle.c file. With this patchset, the processor_idle.c file will
> be the last user of this field.

Daniel,
Thanks for this cleanup.
Hopefully we can hear from somebody with davinci HW who can test it?

Looks like it is now up to me to address processor_idle.c and
finish the job of expunging driver_data.

thanks,
-Len Brown

Intel Open Source Technology Center


> 
> Also, the patchset simplify the code and makes it a bit more clear to read.
> 
> I don't have this hardware, the code is not tested.
> 
> Daniel Lezcano (4):
>   davinci: cpuidle - use global variable for ddr2 flag
>   davinci: cpuidle - move code to prevent forward declaration
>   davinci: cpuidle - remove the ops
>   davinci: cpuidle - remove useless initialization
> 
>  arch/arm/mach-davinci/cpuidle.c |   84 ++++++++++++---------------------------
>  1 file changed, 25 insertions(+), 59 deletions(-)
>