From: Sekhar Nori <nsekhar@ti.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
patches@linaro.org, linaro-dev@lists.linaro.org,
davinci-linux-open-source@linux.davincidsp.com, lenb@kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/4] davinci: cpuidle - use global variable for ddr2 flag
Date: Mon, 4 Feb 2013 15:18:33 +0530 [thread overview]
Message-ID: <510F83F1.7000706@ti.com> (raw)
In-Reply-To: <1359726495-8024-2-git-send-email-daniel.lezcano@linaro.org>
On 2/1/2013 7:18 PM, Daniel Lezcano wrote:
> +static bool ddr2_pdown = false;
checkpatch.pl warned against zero initialization of static variable
here. Other than that the series looks good. I checked that both state0
and state1 are entered on da850 evm. Making power measurements requires
more elaborate setup so I left that out.
Target residency of state1 seems high and it is entered very
infrequently. But that's not something introduced by this series. So for
all the patches, you can add:
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
next prev parent reply other threads:[~2013-02-04 9:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 13:48 [PATCH 0/4] davinci: cpuidle - some cleanups Daniel Lezcano
2013-02-01 13:48 ` [PATCH 1/4] davinci: cpuidle - use global variable for ddr2 flag Daniel Lezcano
2013-02-04 9:48 ` Sekhar Nori [this message]
2013-02-01 13:48 ` [PATCH 2/4] davinci: cpuidle - move code to prevent forward declaration Daniel Lezcano
[not found] ` <1359726495-8024-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-02-01 13:48 ` [PATCH 3/4] davinci: cpuidle - remove the ops Daniel Lezcano
2013-02-01 13:48 ` [PATCH 4/4] davinci: cpuidle - remove useless initialization Daniel Lezcano
2013-02-01 18:49 ` [PATCH 0/4] davinci: cpuidle - some cleanups Len Brown
2013-02-03 11:54 ` Sekhar Nori
2013-02-03 12:22 ` Daniel Lezcano
2013-02-03 13:00 ` Sekhar Nori
2013-02-03 14:13 ` Daniel Lezcano
[not found] ` <510C0E4E.3010008-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-02-04 12:08 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510F83F1.7000706@ti.com \
--to=nsekhar@ti.com \
--cc=daniel.lezcano@linaro.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=lenb@kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).