From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
valdis.kletnieks@vt.edu, artem.savkov@gmail.com,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
robin.randhawa@arm.com, Steve.Bannister@arm.com,
Liviu.Dudau@arm.com, Nathan Zimmer <nzimmer@sgi.com>,
dirk.brandewie@gmail.com
Subject: Re: [PATCH 0/4] CPUFreq Fixes for 3.9
Date: Fri, 08 Feb 2013 16:08:49 -0800 [thread overview]
Message-ID: <51159391.2020002@gmail.com> (raw)
In-Reply-To: <2792362.JXCag4GJsR@vostro.rjw.lan>
On 02/08/2013 03:56 PM, Rafael J. Wysocki wrote:
> On Friday, February 08, 2013 09:02:37 PM Rafael J. Wysocki wrote:
>> On Friday, February 08, 2013 08:06:52 PM Viresh Kumar wrote:
>>> On 8 February 2013 18:02, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>>>> So as I said, please rework the fixes on top of linux-pm.git/pm-cpufreq.
>>>
>>> I already did. Please check for-rafael branch
>>
>> Cool. This is the one I'm supposed to apply, then?
>
> OK, applied to bleeding-edge. Hopefully it will be build-tested over the
> weekend and I can move it to linux-next.
>
> I dropped the rwlock/RCU patches from Nathan, though, because I had some
> doubts about the correctness of the RCU one and the rwlock one alone would
> conflict with your further changes.
One piece of fallout from dropping Nathan patches I had rebased mine on top of
them.
This fixes the breakage do you want me to spin my patches or send this separately?:
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 0ebdf8c..a008b8e 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1024,7 +1024,7 @@ static int __cpufreq_remove_dev(struct device *dev, struct
__cpufreq_governor(data, CPUFREQ_GOV_STOP);
#ifdef CONFIG_HOTPLUG_CPU
- if (!driver->setpolicy)
+ if (!cpufreq_driver->setpolicy)
strncpy(per_cpu(cpufreq_cpu_governor, cpu),
data->governor->name, CPUFREQ_NAME_LEN);
#endif
@@ -1771,7 +1771,7 @@ int cpufreq_update_policy(unsigned int cpu)
pr_debug("Driver did not initialize current freq");
data->cur = policy.cur;
} else {
- if (data->cur != policy.cur && driver->target)
+ if (data->cur != policy.cur && cpufreq_driver->target)
cpufreq_out_of_sync(cpu, data->cur,
policy.cur);
}
next prev parent reply other threads:[~2013-02-09 0:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 10:27 [PATCH 0/4] CPUFreq Fixes for 3.9 Viresh Kumar
[not found] ` <cover.1360232293.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-02-07 10:27 ` [PATCH 1/4] cpufreq: governors: Fix WARN_ON() for multi-policy platforms Viresh Kumar
2013-02-07 10:27 ` [PATCH 2/4] cpufreq: Remove unused HOTPLUG_CPU code Viresh Kumar
2013-02-07 10:27 ` [PATCH 3/4] cpufreq: Create a macro for unlock_policy_rwsem{read, write} Viresh Kumar
2013-02-07 10:27 ` [PATCH 4/4] cpufreq: Fix locking issues Viresh Kumar
2013-02-07 13:05 ` [PATCH 0/4] CPUFreq Fixes for 3.9 Rafael J. Wysocki
2013-02-07 13:22 ` Viresh Kumar
2013-02-07 23:07 ` Rafael J. Wysocki
2013-02-08 2:49 ` Viresh Kumar
2013-02-08 5:09 ` Viresh Kumar
2013-02-08 6:27 ` Artem Savkov
2013-02-07 19:39 ` Artem Savkov
2013-02-08 2:52 ` Viresh Kumar
2013-02-07 23:33 ` Rafael J. Wysocki
2013-02-07 23:48 ` Rafael J. Wysocki
2013-02-08 2:50 ` Viresh Kumar
2013-02-08 12:32 ` Rafael J. Wysocki
2013-02-08 14:36 ` Viresh Kumar
2013-02-08 20:02 ` Rafael J. Wysocki
2013-02-08 23:56 ` Rafael J. Wysocki
2013-02-09 0:08 ` Dirk Brandewie [this message]
2013-02-09 0:21 ` Rafael J. Wysocki
2013-02-09 2:10 ` Viresh Kumar
2013-02-09 11:44 ` Rafael J. Wysocki
2013-02-08 5:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51159391.2020002@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=artem.savkov@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nzimmer@sgi.com \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=valdis.kletnieks@vt.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).