* Re: libata-acpi.c ata_acpi_register_power_resource copy and paste mistake ? [not found] <928867757.20130228174510@eikelenboom.it> @ 2013-03-01 1:59 ` Aaron Lu 2013-03-01 2:11 ` Rafael J. Wysocki 0 siblings, 1 reply; 7+ messages in thread From: Aaron Lu @ 2013-03-01 1:59 UTC (permalink / raw) To: Sander Eikelenboom, Rafael J. Wysocki Cc: Jeff Garzik, linux-kernel, linux-ide, Linux-pm mailing list +Rafael commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Date: Thu Jan 17 14:11:05 2013 +0100 ACPI / PM: Rework the handling of devices depending on power resources -Aaron On 03/01/2013 12:45 AM, Sander Eikelenboom wrote: > Hi Jeff, > > During the last merge of ahci code (d9978ec5680059d727b39d6c706777c6973587f2), i saw this coming by: > > > --- a/drivers/ata/libata-acpi.c > +++ b/drivers/ata/libata-acpi.c > @@ -1024,30 +1024,20 @@ static void ata_acpi_register_power_resource(struct ata_device *dev) > { > struct scsi_device *sdev = dev->sdev; > acpi_handle handle; > - struct device *device; > > handle = ata_dev_acpi_handle(dev); > - if (!handle) > - return; > - > - device = &sdev->sdev_gendev; > - > - acpi_power_resource_register_device(device, handle); > + if (handle) > + acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); > } > > shouldn't: > > acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); > > be > > acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev); > > in the ata_acpi_register_power_resource function ? > > (seems like a copy and paste mistake from the unregister function) > > -- > Sander > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ide" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: libata-acpi.c ata_acpi_register_power_resource copy and paste mistake ? 2013-03-01 1:59 ` libata-acpi.c ata_acpi_register_power_resource copy and paste mistake ? Aaron Lu @ 2013-03-01 2:11 ` Rafael J. Wysocki 2013-03-01 11:16 ` [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource Sander Eikelenboom ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Rafael J. Wysocki @ 2013-03-01 2:11 UTC (permalink / raw) To: Aaron Lu, Sander Eikelenboom Cc: Jeff Garzik, linux-kernel, linux-ide, Linux-pm mailing list On Friday, March 01, 2013 09:59:41 AM Aaron Lu wrote: > +Rafael > > commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Date: Thu Jan 17 14:11:05 2013 +0100 > > ACPI / PM: Rework the handling of devices depending on power resources > > -Aaron Thanks Aaron! > On 03/01/2013 12:45 AM, Sander Eikelenboom wrote: > > Hi Jeff, > > > > During the last merge of ahci code (d9978ec5680059d727b39d6c706777c6973587f2), i saw this coming by: > > > > > > --- a/drivers/ata/libata-acpi.c > > +++ b/drivers/ata/libata-acpi.c > > @@ -1024,30 +1024,20 @@ static void ata_acpi_register_power_resource(struct ata_device *dev) > > { > > struct scsi_device *sdev = dev->sdev; > > acpi_handle handle; > > - struct device *device; > > > > handle = ata_dev_acpi_handle(dev); > > - if (!handle) > > - return; > > - > > - device = &sdev->sdev_gendev; > > - > > - acpi_power_resource_register_device(device, handle); > > + if (handle) > > + acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); > > } > > > > shouldn't: > > > > acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); > > > > be > > > > acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev); > > > > in the ata_acpi_register_power_resource function ? > > > > (seems like a copy and paste mistake from the unregister function) Yes. Sorry, my bad. If you can prepare a patch fixing this, please do that, or I'll do it tomorrow. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource 2013-03-01 2:11 ` Rafael J. Wysocki @ 2013-03-01 11:16 ` Sander Eikelenboom 2013-03-01 16:34 ` Rafael J. Wysocki 2013-03-04 22:15 ` Jeff Garzik 2013-03-01 11:16 ` Sander Eikelenboom 2013-03-01 11:16 ` Sander Eikelenboom 2 siblings, 2 replies; 7+ messages in thread From: Sander Eikelenboom @ 2013-03-01 11:16 UTC (permalink / raw) To: rjw Cc: Sander Eikelenboom, aaron.lu, jgarzik, linux-kernel, linux-ide, linux-pm Fix a copy and paste mistake introduced in: commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 "ACPI / PM: Rework the handling of devices depending on power resources" Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it> --- drivers/ata/libata-acpi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 0ea1018..cb3eab6d 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -1027,7 +1027,7 @@ static void ata_acpi_register_power_resource(struct ata_device *dev) handle = ata_dev_acpi_handle(dev); if (handle) - acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); + acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev); } static void ata_acpi_unregister_power_resource(struct ata_device *dev) -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource 2013-03-01 11:16 ` [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource Sander Eikelenboom @ 2013-03-01 16:34 ` Rafael J. Wysocki 2013-03-04 22:15 ` Jeff Garzik 1 sibling, 0 replies; 7+ messages in thread From: Rafael J. Wysocki @ 2013-03-01 16:34 UTC (permalink / raw) To: Sander Eikelenboom; +Cc: aaron.lu, jgarzik, linux-kernel, linux-ide, linux-pm On Friday, March 01, 2013 12:16:42 PM Sander Eikelenboom wrote: > Fix a copy and paste mistake introduced in: > > commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 > "ACPI / PM: Rework the handling of devices depending on power resources" > > Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/ata/libata-acpi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c > index 0ea1018..cb3eab6d 100644 > --- a/drivers/ata/libata-acpi.c > +++ b/drivers/ata/libata-acpi.c > @@ -1027,7 +1027,7 @@ static void ata_acpi_register_power_resource(struct ata_device *dev) > > handle = ata_dev_acpi_handle(dev); > if (handle) > - acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); > + acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev); > } > > static void ata_acpi_unregister_power_resource(struct ata_device *dev) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource 2013-03-01 11:16 ` [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource Sander Eikelenboom 2013-03-01 16:34 ` Rafael J. Wysocki @ 2013-03-04 22:15 ` Jeff Garzik 1 sibling, 0 replies; 7+ messages in thread From: Jeff Garzik @ 2013-03-04 22:15 UTC (permalink / raw) To: Sander Eikelenboom; +Cc: rjw, aaron.lu, linux-kernel, linux-ide, linux-pm On 03/01/2013 06:16 AM, Sander Eikelenboom wrote: > Fix a copy and paste mistake introduced in: > > commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 > "ACPI / PM: Rework the handling of devices depending on power resources" > > Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it> > --- > drivers/ata/libata-acpi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) applied ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource 2013-03-01 2:11 ` Rafael J. Wysocki 2013-03-01 11:16 ` [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource Sander Eikelenboom @ 2013-03-01 11:16 ` Sander Eikelenboom 2013-03-01 11:16 ` Sander Eikelenboom 2 siblings, 0 replies; 7+ messages in thread From: Sander Eikelenboom @ 2013-03-01 11:16 UTC (permalink / raw) To: rjw Cc: Sander Eikelenboom, aaron.lu, jgarzik, linux-kernel, linux-ide, linux-pm Fix a copy and paste mistake introduced in: commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 "ACPI / PM: Rework the handling of devices depending on power resources" Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it> --- drivers/ata/libata-acpi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 0ea1018..cb3eab6d 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -1027,7 +1027,7 @@ static void ata_acpi_register_power_resource(struct ata_device *dev) handle = ata_dev_acpi_handle(dev); if (handle) - acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); + acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev); } static void ata_acpi_unregister_power_resource(struct ata_device *dev) -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource 2013-03-01 2:11 ` Rafael J. Wysocki 2013-03-01 11:16 ` [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource Sander Eikelenboom 2013-03-01 11:16 ` Sander Eikelenboom @ 2013-03-01 11:16 ` Sander Eikelenboom 2 siblings, 0 replies; 7+ messages in thread From: Sander Eikelenboom @ 2013-03-01 11:16 UTC (permalink / raw) To: rjw Cc: Sander Eikelenboom, aaron.lu, jgarzik, linux-kernel, linux-ide, linux-pm Fix a copy and paste mistake introduced in: commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 "ACPI / PM: Rework the handling of devices depending on power resources" Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it> --- drivers/ata/libata-acpi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 0ea1018..cb3eab6d 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -1027,7 +1027,7 @@ static void ata_acpi_register_power_resource(struct ata_device *dev) handle = ata_dev_acpi_handle(dev); if (handle) - acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); + acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev); } static void ata_acpi_unregister_power_resource(struct ata_device *dev) -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-04 22:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <928867757.20130228174510@eikelenboom.it>
2013-03-01 1:59 ` libata-acpi.c ata_acpi_register_power_resource copy and paste mistake ? Aaron Lu
2013-03-01 2:11 ` Rafael J. Wysocki
2013-03-01 11:16 ` [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource Sander Eikelenboom
2013-03-01 16:34 ` Rafael J. Wysocki
2013-03-04 22:15 ` Jeff Garzik
2013-03-01 11:16 ` Sander Eikelenboom
2013-03-01 11:16 ` Sander Eikelenboom
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).