Re: [PATCH 2/4] cpuidle / omap4 : use CPUIDLE_FLAG_TIMER_STOP flag

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 03/21/2013 02:05 PM, Santosh Shilimkar wrote:
> On Thursday 21 March 2013 06:31 PM, Santosh Shilimkar wrote:
>> $subject
>> s/'cpuidle/omap4' /ARM: CPUidle: OMAP4:
>>
>> On Thursday 21 March 2013 05:51 PM, Daniel Lezcano wrote:
>>> Use the CPUIDLE_FLAG_TIMER_STOP and let the cpuidle framework
>>> to handle the CLOCK_EVT_NOTIFY_BROADCAST_ENTER/EXIT when entering
>>> this state.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> Cc: Len Brown <lenb@kernel.org>
>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Cc: Rajendra Nayak <rnayak@ti.com>
>>> Cc: Sascha Hauer <kernel@pengutronix.de>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> ---
>> Otherwise
>> Akced-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>
> One more comment for this patch as well as imx and ux500 one.
> 
> Remove "#include <linux/clockchips.h>" since it is not needed
> anymore.

Actually, it is still needed for:

omap_setup_broadcast_timer
imx6q_setup_broadcast_timer
ux500_setup_broadcast_timer

I am preparing another round of patches to move these initialization to
the cpuidle framework but I have to take into account the multiple
drivers support which could be impacted, this is why it is a separated
patchset.


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog