From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 13/14] ARM: mvebu: Add thermal support to Armada 370 device tree Date: Sat, 23 Mar 2013 18:18:33 +0400 Message-ID: <514DB9B9.8090601@cogentembedded.com> References: <1363991114-4225-1-git-send-email-ezequiel.garcia@free-electrons.com> <1363991114-4225-14-git-send-email-ezequiel.garcia@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-la0-f45.google.com ([209.85.215.45]:52763 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026Ab3CWOTb (ORCPT ); Sat, 23 Mar 2013 10:19:31 -0400 Received: by mail-la0-f45.google.com with SMTP id er20so9045937lab.32 for ; Sat, 23 Mar 2013 07:19:30 -0700 (PDT) In-Reply-To: <1363991114-4225-14-git-send-email-ezequiel.garcia@free-electrons.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Ezequiel Garcia Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lior Amsalem , Thomas Petazzoni , Jason Cooper , Nobuhiro Iwamatsu , Andrew Lunn , Gregory Clement , Zhang Rui , Sebastian Hesselbarth Hello. On 23-03-2013 2:25, Ezequiel Garcia wrote: > This patch adds support for the thermal controller available in > all Armada 370 boards. This controller has two 4-byte registers: > one to read the thermal sensor, the other for sensor initialization. > Signed-off-by: Ezequiel Garcia > --- > This patch depends on the patch to add Armada 370 support > in the mvebu_thermal driver: > 'thermal: mvebu: Add support for Armada 370 thermal sensor' > arch/arm/boot/dts/armada-370.dtsi | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi > index 8188d13..5831994 100644 > --- a/arch/arm/boot/dts/armada-370.dtsi > +++ b/arch/arm/boot/dts/armada-370.dtsi > @@ -153,5 +153,11 @@ > clocks = <&coreclk 0>; > }; > > + thermal@d0018300 { > + compatible = "marvell,armada370-thermal"; > + reg = <0xd0018300 0x4 > + 0xd0018304 0x4>; As the two registers are adjacent to each other, why have two register regions ISO one? WBR, Sergei