linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Lior Amsalem <alior@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 13/14] ARM: mvebu: Add thermal support to Armada 370 device tree
Date: Sat, 23 Mar 2013 18:20:15 +0400	[thread overview]
Message-ID: <514DBA1F.6050701@cogentembedded.com> (raw)
In-Reply-To: <514DB9B9.8090601@cogentembedded.com>

On 23-03-2013 18:18, Sergei Shtylyov wrote:

>> This patch adds support for the thermal controller available in
>> all Armada 370 boards. This controller has two 4-byte registers:
>> one to read the thermal sensor, the other for sensor initialization.

>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>> ---
>> This patch depends on the patch to add Armada 370 support
>> in the mvebu_thermal driver:
>> 'thermal: mvebu: Add support for Armada 370 thermal sensor'

>>   arch/arm/boot/dts/armada-370.dtsi |    6 ++++++
>>   1 files changed, 6 insertions(+), 0 deletions(-)

>> diff --git a/arch/arm/boot/dts/armada-370.dtsi
>> b/arch/arm/boot/dts/armada-370.dtsi
>> index 8188d13..5831994 100644
>> --- a/arch/arm/boot/dts/armada-370.dtsi
>> +++ b/arch/arm/boot/dts/armada-370.dtsi
>> @@ -153,5 +153,11 @@
>>               clocks = <&coreclk 0>;
>>           };
>>
>> +        thermal@d0018300 {
>> +            compatible = "marvell,armada370-thermal";
>> +            reg = <0xd0018300 0x4
>> +                   0xd0018304 0x4>;

>     As the two registers are adjacent to each other, why have two register
> regions ISO one?

    Ah, I just saw the previous patch where the registers are not adjacent and 
it became clear why.

WBR, Sergei


  reply	other threads:[~2013-03-23 14:21 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 22:25 [PATCH v2 00/14] Marvell EBU thermal sensor consolidation Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 01/14] thermal: Rename driver 'kirkwood' -> 'mvebu' Ezequiel Garcia
2013-04-11 16:00   ` [v2,01/14] " Eduardo Valentin
2013-04-11 16:31     ` Ezequiel Garcia
2013-04-11 18:47       ` Eduardo Valentin
2013-04-11 18:57         ` Eduardo Valentin
2013-04-11 19:09         ` Ezequiel Garcia
2013-04-11 16:21   ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 02/14] thermal: mvebu: Rename symbols " Ezequiel Garcia
2013-04-11 16:18   ` [v2,02/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 03/14] thermal: mvebu: Move MODULE_DEVICE_TABLE upwards Ezequiel Garcia
2013-04-11 16:25   ` [v2,03/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 04/14] thermal: mvebu: Remove unneeded variable initialization Ezequiel Garcia
2013-04-11 16:29   ` [v2,04/14] " Eduardo Valentin
2013-04-11 18:54     ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 05/14] thermal: mvebu: Convert to devm_ioremap_resource() Ezequiel Garcia
2013-04-11 16:35   ` [v2,05/14] " Eduardo Valentin
2013-04-11 18:55     ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 06/14] thermal: mvebu: Fix license declaration Ezequiel Garcia
2013-04-11 16:40   ` [v2,06/14] " Eduardo Valentin
2013-04-11 18:55     ` Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 07/14] thermal: mvebu: Rename kirkwood definitions to mvebu Ezequiel Garcia
2013-04-11 16:43   ` [v2,07/14] " Eduardo Valentin
2013-03-22 22:25 ` [PATCH v2 08/14] thermal: mvebu: Add infrastructure to support more multiple SoC variants Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 09/14] thermal: mvebu: Add support for Armada XP thermal sensor Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 10/14] thermal: mvebu: Add support for Armada 370 " Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 11/14] thermal: mvebu: Add support for Marvell Dove SoC family Ezequiel Garcia
2013-03-23 11:26   ` Sebastian Hesselbarth
2013-03-24  0:16     ` Ezequiel Garcia
2013-03-25  9:34     ` Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 12/14] ARM: mvebu: Add thermal support to Armada XP device tree Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 13/14] ARM: mvebu: Add thermal support to Armada 370 " Ezequiel Garcia
2013-03-23 14:18   ` Sergei Shtylyov
2013-03-23 14:20     ` Sergei Shtylyov [this message]
2013-03-23 14:25       ` Sergei Shtylyov
2013-03-24  0:22         ` Ezequiel Garcia
2013-03-22 22:25 ` [PATCH v2 14/14] ARM: configs: Update mvebu, dove and kirkwood defconfigs for thermal Ezequiel Garcia
2013-03-23 18:16 ` [PATCH v2 00/14] Marvell EBU thermal sensor consolidation Jason Cooper
2013-03-23 18:28   ` Sebastian Hesselbarth
2013-03-23 18:31     ` Jason Cooper
2013-03-23 18:38       ` Sebastian Hesselbarth
2013-03-25  9:30 ` Andrew Lunn
2013-03-25 10:45   ` Ezequiel Garcia
2013-03-25 12:23     ` Sebastian Hesselbarth
2013-03-25 12:39       ` Ezequiel Garcia
2013-03-25 13:58         ` Sebastian Hesselbarth
2013-03-25 16:29         ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514DBA1F.6050701@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=iwamatsu@nigauri.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).