From: Len Brown <lenb@kernel.org>
To: "Mansoor, Illyas" <illyas.mansoor@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, X86 <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Matthew Garrett <matthew.garrett@nebula.com>,
Tejun Heo <tj@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Rudramuni, Vishwesh M" <vishwesh.m.rudramuni@intel.com>,
"richard@nod.at" <richard@nod.at>,
"josh@joshtriplett.org" <josh@joshtriplett.org>,
"Kumar P, Mahesh" <mahesh.kumar.p@intel.com>,
"Sil, Dyut K" <dyut.k.sil@intel.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] x86: fix idle notifier not being called in CONFIG_X86_32
Date: Mon, 25 Mar 2013 12:48:58 -0400 [thread overview]
Message-ID: <51507FFA.4020403@kernel.org> (raw)
In-Reply-To: <810586B7581CC8469141DADEBC37191224F773F0@BGSMSX102.gar.corp.intel.com>
I'm okay with this patch since it makes 32-bit and 64-bit consistent,
and technically, it fixes a regression.
If/when we get rid of the notifier, we should do it for both 32-and
64-bit at the same time.
It isn't clear to me that Alex's work will solve this particular
problem, or that there is a code or logical conflict -- though
maybe you are referring to some code I've not read yet.
So for this trivial patch...
Acked-by: Len Brown <len.brown@intel.com>
But I think the bigger problem here is the expectation that out of tree
drivers will not break. The interactive governor is not upstream.
Len Brown, Intel Open Source Technology Center
prev parent reply other threads:[~2013-03-25 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 5:41 [PATCH] x86: fix idle notifier not being called in CONFIG_X86_32 Illyas Mansoor
2013-03-06 10:18 ` Ingo Molnar
2013-03-06 10:20 ` Mansoor, Illyas
2013-03-06 10:36 ` Ingo Molnar
2013-03-06 10:56 ` Mansoor, Illyas
2013-03-25 16:48 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51507FFA.4020403@kernel.org \
--to=lenb@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=dyut.k.sil@intel.com \
--cc=fweisbec@gmail.com \
--cc=illyas.mansoor@intel.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mahesh.kumar.p@intel.com \
--cc=matthew.garrett@nebula.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vishwesh.m.rudramuni@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).