From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
amit.daniel@samsung.com, durgadoss.r@intel.com, andi@lisas.de
Subject: Re: [RFC,4/5] Thermal: governor API cleanup
Date: Tue, 26 Mar 2013 18:35:35 -0400 [thread overview]
Message-ID: <515222B7.8060506@ti.com> (raw)
In-Reply-To: <1364315169-15427-5-git-send-email-rui.zhang@intel.com>
On 26-03-2013 12:26, Zhang Rui wrote:
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>
> ---
> drivers/thermal/thermal_core.c | 2 --
> drivers/thermal/thermal_core.h | 2 ++
> include/linux/thermal.h | 3 ---
Please also clean Documentation/thermal/sysfs_api.txt
> 3 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index eac9745..f645757 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -99,7 +99,6 @@ int thermal_register_governor(struct thermal_governor *governor)
>
> return err;
> }
> -EXPORT_SYMBOL_GPL(thermal_register_governor);
>
> void thermal_unregister_governor(struct thermal_governor *governor)
> {
> @@ -127,7 +126,6 @@ void thermal_unregister_governor(struct thermal_governor *governor)
> mutex_unlock(&thermal_governor_lock);
> return;
> }
> -EXPORT_SYMBOL_GPL(thermal_unregister_governor);
>
> static int get_idr(struct idr *idr, struct mutex *lock, int *id)
> {
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index f84ea0f..a1f8278 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -50,6 +50,8 @@ struct thermal_instance {
> struct list_head cdev_node; /* node in cdev->thermal_instances */
> };
>
> +extern int thermal_register_governor(struct thermal_governor *);
> +extern void thermal_unregister_governor(struct thermal_governor *);
Does this really need to be extern?
>
> #ifdef CONFIG_THERMAL_GOV_STEP_WISE
> extern int thermal_gov_step_wise_register(void);
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 2eeec01..af03ea6 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -243,9 +243,6 @@ struct thermal_instance *get_thermal_instance(struct thermal_zone_device *,
> void thermal_cdev_update(struct thermal_cooling_device *);
> void notify_thermal_framework(struct thermal_zone_device *, int);
>
> -int thermal_register_governor(struct thermal_governor *);
> -void thermal_unregister_governor(struct thermal_governor *);
> -
> #ifdef CONFIG_NET
> extern int thermal_generate_netlink_event(struct thermal_zone_device *tz,
> enum events event);
>
next prev parent reply other threads:[~2013-03-26 22:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:26 [RFC PATCH 0/5] Thermal: build all thermal framework code into thermal_sys module Zhang Rui
2013-03-26 16:26 ` [RFC PATCH 1/5] Thermal: rename thermal_sys.c to thermal_core.c Zhang Rui
2013-03-26 16:56 ` R, Durgadoss
2013-03-26 17:08 ` Zhang Rui
2013-03-26 22:04 ` [RFC,1/5] " Eduardo Valentin
2013-03-28 2:40 ` Zhang Rui
2013-04-01 12:43 ` Eduardo Valentin
2013-04-01 13:09 ` R, Durgadoss
2013-03-26 16:26 ` [RFC PATCH 2/5] Thermal: thermal framework registration failure case cleanup Zhang Rui
2013-03-26 22:22 ` [RFC, " Eduardo Valentin
2013-03-26 16:26 ` [RFC PATCH 3/5] Thermal: build thermal governors into thermal_sys module Zhang Rui
2013-03-26 16:53 ` R, Durgadoss
2013-03-26 17:12 ` Zhang Rui
2013-03-26 22:31 ` [RFC,3/5] " Eduardo Valentin
2013-03-26 16:26 ` [RFC PATCH 4/5] Thermal: governor API cleanup Zhang Rui
2013-03-26 22:35 ` Eduardo Valentin [this message]
2013-03-26 16:26 ` [RFC PATCH 5/5] Thermal: build cpu_cooling code into thermal_sys module Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515222B7.8060506@ti.com \
--to=eduardo.valentin@ti.com \
--cc=amit.daniel@samsung.com \
--cc=andi@lisas.de \
--cc=durgadoss.r@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).