From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 7/9] intel: cpuidle: remove stop/start critical timings Date: Mon, 08 Apr 2013 19:40:37 +0200 Message-ID: <51630115.6040205@linaro.org> References: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org> <1364991322-20585-7-git-send-email-daniel.lezcano@linaro.org> <3375360.P4DAA9Jd5Y@vostro.rjw.lan> <5161DC9C.3020703@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5161DC9C.3020703-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: Len Brown , deepthi-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, rnayak-l0cyMroinI0@public.gmane.org, josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-pm@vger.kernel.org On 04/07/2013 10:52 PM, Daniel Lezcano wrote: > On 04/05/2013 12:31 AM, Rafael J. Wysocki wrote: >> On Wednesday, April 03, 2013 02:15:20 PM Daniel Lezcano wrote: >>> The start/stop_critical_timings are called from arch/x86/kernel/pro= cess.c >>> in the cpu_idle loop function. >>> >>> Remove the ones in the cpuidle driver. >>> >>> Signed-off-by: Daniel Lezcano >> For this one I need an ACK from Len. >> >> Len, any objections? > > Len ? ping ... Rafael, this patch is not dependent from any patch in the series, is it possibl= e you apply the patchset except this patch ? May be you can apply it later when Len acks it, or I can resend it, no = ? I have a lot of code consolidation patches awaiting for this patchset t= o be merged. Thanks -- Daniel > --- > drivers/idle/intel_idle.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > index 5d66750..c99c31e 100644 > --- a/drivers/idle/intel_idle.c > +++ b/drivers/idle/intel_idle.c > @@ -339,7 +339,6 @@ static int intel_idle(struct cpuidle_device *dev, > if (!(lapic_timer_reliable_states & (1 << (cstate)))) > clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &cpu); > =20 > - stop_critical_timings(); > if (!need_resched()) { > =20 > __monitor((void *)¤t_thread_info()->flags, 0, 0); > @@ -348,8 +347,6 @@ static int intel_idle(struct cpuidle_device *dev, > __mwait(eax, ecx); > } > =20 > - start_critical_timings(); > - > if (!(lapic_timer_reliable_states & (1 << (cstate)))) > clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu); > =20 > > --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog