From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 1/9] ARM: cpuidle: remove useless declaration Date: Mon, 08 Apr 2013 22:53:54 +0200 Message-ID: <51632E62.2060300@linaro.org> References: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org> <515C1F3B.5040008@linaro.org> <3144551.suxBcA9vOB@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f48.google.com ([74.125.82.48]:57591 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763054Ab3DHUyB (ORCPT ); Mon, 8 Apr 2013 16:54:01 -0400 Received: by mail-wg0-f48.google.com with SMTP id m15so6314303wgh.27 for ; Mon, 08 Apr 2013 13:53:59 -0700 (PDT) In-Reply-To: <3144551.suxBcA9vOB@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" Cc: Russell King - ARM Linux , deepthi@linux.vnet.ibm.com, linaro-kernel@lists.linaro.org, swarren@wwwdotorg.org, patches@linaro.org, linux-pm@vger.kernel.org, rnayak@ti.com, nsekhar@ti.com, josephl@nvidia.com, linux-tegra@vger.kernel.org, horms+renesas@verge.net.au, linux-arm-kernel@lists.infradead.org, lenb@kernel.org On 04/08/2013 10:50 PM, Rafael J. Wysocki wrote: > On Wednesday, April 03, 2013 02:23:23 PM Daniel Lezcano wrote: >> On 04/03/2013 02:15 PM, Daniel Lezcano wrote: >>> The noop functions code is not necessary because the header file is >>> included in files which are compiled when CONFIG_CPU_IDLE is on. >>> >>> Signed-off-by: Daniel Lezcano >> >> I have been involved in the development of this file. I know Rob is = no >> longer working on this neither monitoring the code. >> >> Russell are you ok with this patch ? Rafael needs your ack to take t= his >> patch into its tree. >=20 > Well, since nothing in the cpuidle directory seems to really depend o= n this > patch, my suggestion is to merge it through the ARM tree when suitabl= e. Ok. >>> --- >>> arch/arm/include/asm/cpuidle.h | 7 +------ >>> 1 file changed, 1 insertion(+), 6 deletions(-) >>> >>> diff --git a/arch/arm/include/asm/cpuidle.h b/arch/arm/include/asm/= cpuidle.h >>> index 2fca60a..7367787 100644 >>> --- a/arch/arm/include/asm/cpuidle.h >>> +++ b/arch/arm/include/asm/cpuidle.h >>> @@ -1,13 +1,8 @@ >>> #ifndef __ASM_ARM_CPUIDLE_H >>> #define __ASM_ARM_CPUIDLE_H >>> =20 >>> -#ifdef CONFIG_CPU_IDLE >>> extern int arm_cpuidle_simple_enter(struct cpuidle_device *dev, >>> - struct cpuidle_driver *drv, int index); >>> -#else >>> -static inline int arm_cpuidle_simple_enter(struct cpuidle_device *= dev, >>> - struct cpuidle_driver *drv, int index) { return -ENODEV; } >>> -#endif >>> + struct cpuidle_driver *drv, int index); >>> =20 >>> /* Common ARM WFI state */ >>> #define ARM_CPUIDLE_WFI_STATE_PWR(p) {\ >> >> >> --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog