From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [v2,04/14] thermal: mvebu: Remove unneeded variable initialization Date: Thu, 11 Apr 2013 14:54:17 -0400 Message-ID: <516706D9.6000604@ti.com> References: <1363991114-4225-5-git-send-email-ezequiel.garcia@free-electrons.com> <5166E4E2.1080606@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:36760 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606Ab3DKSyv (ORCPT ); Thu, 11 Apr 2013 14:54:51 -0400 In-Reply-To: <5166E4E2.1080606@ti.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Eduardo Valentin Cc: Ezequiel Garcia , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Lior Amsalem , Zhang Rui , Nobuhiro Iwamatsu , Thomas Petazzoni , Gregory Clement , Sebastian Hesselbarth , Andrew Lunn Ezequiel, On 11-04-2013 12:29, Eduardo Valentin wrote: > Rui, Ezequiel, > > On 22-03-2013 18:25, Ezequiel Garcia wrote: >> This variable is used only after it's properly initialized, >> so there's no need to set it to NULL in its declaration. >> >> Signed-off-by: Ezequiel Garcia >> > > I am fine with this patch. Though it doesn t hurt to have this > initialization, the code looks cleaner though. > > Acked-by: Eduardo Valentin I know you have discarded the idea of merging the driver into a single driver, but can you please resend this patch on top of drivers/thermal/kirkwood_thermal.c file. This change still applies. > > >> --- >> drivers/thermal/mvebu_thermal.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/thermal/mvebu_thermal.c >> b/drivers/thermal/mvebu_thermal.c >> index 031f94d..1f502ed 100644 >> --- a/drivers/thermal/mvebu_thermal.c >> +++ b/drivers/thermal/mvebu_thermal.c >> @@ -72,7 +72,7 @@ MODULE_DEVICE_TABLE(of, mvebu_thermal_id_table); >> >> static int mvebu_thermal_probe(struct platform_device *pdev) >> { >> - struct thermal_zone_device *thermal = NULL; >> + struct thermal_zone_device *thermal; >> struct mvebu_thermal_priv *priv; >> struct resource *res; >> >> > > >