From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 04/18] ARM: imx: cpuidle: create separate drivers for imx5/imx6 Date: Fri, 12 Apr 2013 09:12:40 +0200 Message-ID: <5167B3E8.2020007@linaro.org> References: <1365603743-5618-1-git-send-email-daniel.lezcano@linaro.org> <1365603743-5618-5-git-send-email-daniel.lezcano@linaro.org> <20130412060527.GA16494@S2101-09.ap.freescale.net> <5167B0AC.2000308@linaro.org> <20130412071124.GL16970@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:47391 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451Ab3DLHMp (ORCPT ); Fri, 12 Apr 2013 03:12:45 -0400 Received: by mail-wg0-f44.google.com with SMTP id z11so2322888wgg.23 for ; Fri, 12 Apr 2013 00:12:43 -0700 (PDT) In-Reply-To: <20130412071124.GL16970@S2101-09.ap.freescale.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Shawn Guo Cc: andrew@lunn.ch, khilman@deeprootsystems.com, nsekhar@ti.com, josephl@nvidia.com, kgene.kim@samsung.com, patches@linaro.org, magnus.damm@gmail.com, tony@atomide.com, plagnioj@jcrosoft.com, linaro-kernel@lists.linaro.org, jason@lakedaemon.net, swarren@wwwdotorg.org, rob.herring@calxeda.com, rjw@sisk.pl, horms@verge.net.au, linux@maxim.org.za, linux-arm-kernel@lists.infradead.org, deepthi@linux.vnet.ibm.com, jkosina@suse.cz, linux-pm@vger.kernel.org, lethal@linux-sh.org, kernel@pengutronix.de On 04/12/2013 09:11 AM, Shawn Guo wrote: > On Fri, Apr 12, 2013 at 08:58:52AM +0200, Daniel Lezcano wrote: >> On 04/12/2013 08:05 AM, Shawn Guo wrote: >>> On Wed, Apr 10, 2013 at 04:22:09PM +0200, Daniel Lezcano wrote: >>>> The code intializes the cpuidle driver at different places. >>>> The cpuidle driver for : >>>> * imx5 : is in the pm-imx5.c, the init function is in cpuidle.c >>>> * imx6 : is in cpuidle-imx6q.c, the init function is in cpuidle.= c >>>> and cpuidle-imx6q.c >>>> >>>> Instead of having the cpuidle code spread across different files, >>>> let's write a driver for each SoC and make the code similar. >>>> >>>> That implies some code duplication but that will be fixed with the >>>> next patches which consolidate the initialization for all the driv= ers. >>>> >>> IMO, this is unnecessary churn. I agree that we can have cpuidle-i= mx5.c >>> instead of carrying imx5 cpuidle code in pm-imx5.c. But removing >>> cpuidle.c and duplicating what imx_cpuidle_init() does into imx5 an= d >>> imx6q driver is a step backward to me. >>> I suggest simply merging this patch into "[PATCH 18/18] ARM: imx: >>> cpuidle: use init/exit common routine" >> >> Yes, I am aware that can can look weird but that was to have the >> different steps to reach the common register function. >> If I merge this patch with the patch 18, I am afraid the modificatio= n >> won't be obvious to the one who will read the patch later (eg. for a= git >> bisect). >> >> It is quite easy to fold the patches, but with the comment above do = you >> still want me to do that ? >=20 > You can have a separate patch introducing cpuidle-imx5.c, but please = do > not duplicate what imx_cpuidle_init() does into cpuidle-imx5.c and > cpuidle-imx6q.c. Sure. Thanks ! -- Daniel --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog