From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Simon Horman <horms@verge.net.au>
Cc: lethal@linux-sh.org, rjw@sisk.pl, linux-sh@vger.kernel.org,
linux-pm@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 1/4] SH: cpuidle: remove pointless initialization
Date: Thu, 18 Apr 2013 11:18:04 +0200 [thread overview]
Message-ID: <516FBA4C.6020100@linaro.org> (raw)
In-Reply-To: <20130418011816.GD4511@verge.net.au>
On 04/18/2013 03:18 AM, Simon Horman wrote:
> On Wed, Apr 17, 2013 at 03:32:54PM +0200, Daniel Lezcano wrote:
>> The driver is a global static variable automatically initialized to zero.
>>
>> Removing the useless initialization in the init function.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Hi Daniel,
>
> All four patches in this series seem reasonable to me.
>
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> Please let me know if I should take them through my renesas tree.
If you are ok with that, is it possible to take them through the
linux-pm tree ? So the cpuidle drivers are synced and I can continue the
code consolidation ?
Thanks for the review.
-- Daniel
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-04-18 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 13:32 [PATCH 1/4] SH: cpuidle: remove pointless initialization Daniel Lezcano
2013-04-17 13:32 ` [PATCH 2/4] SH: cpuidle: remove CPUIDLE_DRIVER_STATE_START usage Daniel Lezcano
2013-04-17 13:32 ` [PATCH 3/4] SH: cpuidle: initialize the driver's states directly Daniel Lezcano
2013-04-17 13:32 ` [PATCH 4/4] SH: cpuidle: check error code at init Daniel Lezcano
2013-04-18 1:18 ` [PATCH 1/4] SH: cpuidle: remove pointless initialization Simon Horman
2013-04-18 9:18 ` Daniel Lezcano [this message]
2013-04-18 13:34 ` Simon Horman
2013-04-18 13:35 ` Daniel Lezcano
2013-04-21 23:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516FBA4C.6020100@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=horms@verge.net.au \
--cc=lethal@linux-sh.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).