From: Arjan van de Ven <arjan@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Alex Shi <alex.shi@intel.com>,
Linux PM list <linux-pm@vger.kernel.org>,
"Brown, Len" <len.brown@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
LKP ML <lkp@linux.intel.com>
Subject: Re: bltk-game regressions on snb laptop
Date: Fri, 19 Apr 2013 08:44:42 -0700 [thread overview]
Message-ID: <5171666A.6040003@linux.intel.com> (raw)
In-Reply-To: <CAKohpongtqt0Sdc95TTrJ+s5A3Xt7df+SmtBZNyHzQKtARLxKA@mail.gmail.com>
>
> So you get better performance without my patch because we don't allocate
> any struct cpufreq_policy for any of the cpus leaving first one. And so only
> manage freq change for it and all other cpus stay at max power..
>
> So, we clearly need to know why don't we want to have all cpus set in
> policy->cpus, when they actually share clock line?
>
right conclusion, wrong solution ;-)
Alex should know by now (we told him this internally quite a few times) that this indeed is happening.
But the answer is not to try to make the software know that things share a clock line,
the answer is that the current code is correct.
(on x86, the way shared voltage/frequency domains work is that the current clock value is the maximum of
what the individual *non idle* cpu's asked for. If the cpu asking for the highest value goes idle,
all others will drop their frequency to the value the next highest is asking for, etc.
Trying to do this kind of thing in software is backwards and actually ends up burning a lot of power)
on the 'regression'; of COURSE things might go slower once you stop acting like the "performance" governor.
now, ondemand is pretty dire for this generation of hardware, and that's why we have asked Alex repeatedly
to actually use the driver Intel has gotten upstream for this generation of hardware instead.
I do not know why he has not done that instead of trying to get a bug put back into the kernel.
prev parent reply other threads:[~2013-04-19 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 7:14 bltk-game regressions on snb laptop Alex Shi
2013-04-17 16:34 ` Rafael J. Wysocki
2013-04-18 0:23 ` Alex Shi
2013-04-17 16:46 ` Viresh Kumar
2013-04-18 0:48 ` Alex Shi
2013-04-18 4:26 ` Viresh Kumar
2013-04-18 4:36 ` Viresh Kumar
2013-04-18 5:24 ` Alex Shi
2013-04-18 5:16 ` Alex Shi
2013-04-18 5:37 ` Viresh Kumar
2013-04-18 6:16 ` Alex Shi
2013-04-18 8:54 ` Alex Shi
2013-04-18 10:01 ` Viresh Kumar
2013-04-19 10:00 ` Alex Shi
2013-04-19 12:23 ` Viresh Kumar
2013-04-19 14:43 ` Alex Shi
2013-04-19 15:44 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5171666A.6040003@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=alex.shi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).