From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH v2] ARM: S5pv210: compiling issue, ARM_S5PV210_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y Date: Wed, 24 Apr 2013 19:11:47 +0800 Message-ID: <5177BDF3.1080604@asianux.com> References: <5177B562.40400@asianux.com> <5177BBB4.4040600@asianux.com> <5177BC50.6050402@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Viresh Kumar Cc: "kgene.kim@samsung.com" , Russell King - ARM Linux , Arnd Bergmann , Will Deacon , rjw@sisk.pl, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-pm@vger.kernel.org On 2013=E5=B9=B404=E6=9C=8824=E6=97=A5 19:10, Viresh Kumar wrote: > On Wed, Apr 24, 2013 at 4:34 PM, Chen Gang wr= ote: >> > >> > For arm S5pv210 with allmodconfig, ARM_S5PV210_CPUFREQ need >> > CONFIG_CPU_FREQ_TABLE=3Dy, or will cause compiling issue. >> > >> > The related operation: >> > + arm-linux-gnu-ld -EL -p --no-undefined -X --build-id -X -o .tmp_= vmlinux1 -T /root/linux-next/arch/arm/kernel/vmlinux.lds arch/arm/kerne= l/head.o init/built-in.o --start-group usr/built-in.o arch/arm/nwfpe/bu= ilt-in.o arch/arm/vfp/built-in.o arch/arm/kernel/built-in.o arch/arm/mm= /built-in.o arch/arm/common/built-in.o arch/arm/net/built-in.o arch/arm= /crypto/built-in.o arch/arm/mach-s5pv210/built-in.o arch/arm/plat-samsu= ng/built-in.o kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-i= n.o security/built-in.o crypto/built-in.o block/built-in.o arch/arm/lib= /lib.a lib/lib.a arch/arm/lib/built-in.o lib/built-in.o drivers/built-i= n.o sound/built-in.o firmware/built-in.o net/built-in.o --end-group >> > >> > The related errors: >> > drivers/built-in.o: In function `s5pv210_target': >> > drivers/cpufreq/s5pv210-cpufreq.c:225: undefined reference to `cpu= freq_frequency_table_target' >> > drivers/cpufreq/s5pv210-cpufreq.c:237: undefined reference to `cpu= freq_frequency_table_target' >> > drivers/built-in.o: In function `s5pv210_verify_speed': >> > drivers/cpufreq/s5pv210-cpufreq.c:182: undefined reference to `cpu= freq_frequency_table_verify' >> > drivers/built-in.o: In function `s5pv210_cpu_init': >> > drivers/cpufreq/s5pv210-cpufreq.c:556: undefined reference to `cpu= freq_frequency_table_get_attr' >> > drivers/cpufreq/s5pv210-cpufreq.c:560: undefined reference to `cpu= freq_frequency_table_cpuinfo' >> > make: *** [vmlinux] Error 1 >> > >> > Signed-off-by: Chen Gang >> > --- >> > drivers/cpufreq/Kconfig.arm | 1 + >> > 1 files changed, 1 insertions(+), 0 deletions(-) >> > >> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig= =2Earm >> > index bce2195..bbcd719 100644 >> > --- a/drivers/cpufreq/Kconfig.arm >> > +++ b/drivers/cpufreq/Kconfig.arm >> > @@ -187,6 +187,7 @@ config ARM_S3C64XX_CPUFREQ >> > config ARM_S5PV210_CPUFREQ >> > bool "Samsung S5PV210 and S5PC110" >> > depends on CPU_S5PV210 >> > + select CPU_FREQ_TABLE > Acked-by: Viresh Kumar >=20 >=20 Thank you very much. --=20 Chen Gang Asianux Corporation