From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: "Jarzmik, Robert" <robert.jarzmik@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"R, Durgadoss" <durgadoss.r@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: S3, SMP non boot cpus and /sys/devices/system/cpu[1-9]/cpufreq/scaling_max_freq
Date: Tue, 14 May 2013 19:46:24 +0530 [thread overview]
Message-ID: <51924738.2000301@linux.vnet.ibm.com> (raw)
In-Reply-To: <65F5F98566038744B1B43C8FD3B7549F1911A4A2@IRSMSX104.ger.corp.intel.com>
On 05/14/2013 07:31 PM, Jarzmik, Robert wrote:
> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@sisk.pl]
> Sent: Tuesday, May 14, 2013 2:59 PM
> To: Jarzmik, Robert
> Cc: R, Durgadoss; Srivatsa S. Bhat; Viresh Kumar; linux-pm@vger.kernel.org; Greg Kroah-Hartman
> Subject: Re: S3, SMP non boot cpus and /sys/devices/system/cpu[1-9]/cpufreq/scaling_max_freq
>
[...]
>> One can argue that we're doing too much during system suspend, because what we really need is the _cpu_down() down the road. That said we need to let cpufreq (and other subsystems too) know that this CPU is gone temporarily and it is good to have a clean state in case it doesn't come up later.
> Agreed.
>
>> So I think that the cleanest way to address this issue would be to rearrange the code so that the sysfs is not modified by suspend/resume at all, unless the resume fails, but I don't think it's going to be easy to make that happen.
> I think I miss the point in there, as a failing resume path
> should be catchable in the cpufreq framework. Well,
> I should have a closer look in here.
>
Please take a look at the v2 of the patch that I sent out
just now. IMHO it addresses Rafael's concern adequately.
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2013-05-14 14:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 13:01 S3, SMP non boot cpus and /sys/devices/system/cpu[1-9]/cpufreq/scaling_max_freq Jarzmik, Robert
2013-05-13 20:40 ` Srivatsa S. Bhat
2013-05-13 23:32 ` Rafael J. Wysocki
2013-05-14 9:06 ` Jarzmik, Robert
2013-05-14 10:09 ` Srivatsa S. Bhat
2013-05-14 10:22 ` Viresh Kumar
2013-05-14 10:27 ` Srivatsa S. Bhat
2013-05-14 11:22 ` Rafael J. Wysocki
2013-05-14 11:20 ` R, Durgadoss
2013-05-14 11:33 ` Rafael J. Wysocki
2013-05-14 11:36 ` R, Durgadoss
2013-05-14 11:54 ` Jarzmik, Robert
2013-05-14 12:34 ` Srivatsa S. Bhat
2013-05-14 13:00 ` Rafael J. Wysocki
2013-05-14 13:54 ` Srivatsa S. Bhat
2013-05-14 20:22 ` Rafael J. Wysocki
2013-05-15 8:24 ` Jarzmik, Robert
2013-05-15 8:37 ` R, Durgadoss
2013-05-15 6:16 ` Viresh Kumar
2013-05-15 6:30 ` Srivatsa S. Bhat
2013-05-15 6:45 ` Viresh Kumar
2013-05-15 7:33 ` Srivatsa S. Bhat
2013-05-15 7:44 ` Viresh Kumar
2013-05-15 8:18 ` Srivatsa S. Bhat
2013-05-15 20:50 ` Rafael J. Wysocki
2013-05-14 12:58 ` Rafael J. Wysocki
2013-05-14 14:01 ` Jarzmik, Robert
2013-05-14 14:16 ` Srivatsa S. Bhat [this message]
2013-05-14 14:05 ` Alan Stern
2013-05-15 9:20 ` Jarzmik, Robert
2013-05-15 14:15 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51924738.2000301@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=durgadoss.r@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=robert.jarzmik@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox