From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table Date: Tue, 14 May 2013 10:15:33 -0600 Message-ID: <51926325.2050805@wwwdotorg.org> References: <7e12acada8adcba5f4eb72f6c49e38aaf00a294f.1368434974.git.viresh.kumar@linaro.org> <5191148E.7050205@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: cpufreq-owner@vger.kernel.org To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, Sekhar Nori , Ben Dooks , Kukjin Kim , Simon Horman , Magnus Damm , Ralf Baechle , Arnd Bergmann , Benjamin Herrenschmidt , Paul Mackerras , Olof Johansson , Srinidhi Kasagar , Linus Walleij List-Id: linux-pm@vger.kernel.org On 05/14/2013 07:46 AM, Viresh Kumar wrote: ... > This must address your concerns: > @Rafael: I have attached both patches now for you to apply. > > From: Viresh Kumar > Date: Tue, 14 May 2013 19:08:50 +0530 > Subject: [PATCH 1/2] cpufreq: tegra: Remove irrelevant comment > > Tegra cpufreq driver doesn't use .index field of cpufreq_frequency_table and so > comment mentioning order of .index is irrelevant. Remove it. > diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c > -/* Frequency table index must be sequential starting at 0 */ > static struct cpufreq_frequency_table freq_table[] = { > { 0, 216000 }, > { 1, 312000 }, Does the .index/.data field even need to be filled in any more?