* [PATCH 1/1] Thermal: spear: Fix compilation error
@ 2013-05-21 9:20 Sachin Kamat
2013-05-21 9:35 ` Viresh Kumar
2013-05-23 15:10 ` Eduardo Valentin
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-05-21 9:20 UTC (permalink / raw)
To: linux-pm
Cc: eduardo.valentin, rui.zhang, sachin.kamat, Vincenzo Frascino,
Viresh Kumar
Fixes the following compilation error introduced by commit 253e3ae170
(Thermal: spear_thermal: convert to devm_ioremap_resource).
drivers/thermal/spear_thermal.c: In function ‘spear_thermal_probe’:
drivers/thermal/spear_thermal.c:123:46: error: ‘dev’ undeclared
(first use in this function)
stdev->thermal_base = devm_ioremap_resource(dev, res);
While at it also remove the error message as devm_ioremap_resource()
provides its own error messages.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
Compile tested and based on linux-next (20130521).
---
drivers/thermal/spear_thermal.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
index fa30918..813add6 100644
--- a/drivers/thermal/spear_thermal.c
+++ b/drivers/thermal/spear_thermal.c
@@ -120,11 +120,9 @@ static int spear_thermal_probe(struct platform_device *pdev)
/* Enable thermal sensor */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- stdev->thermal_base = devm_ioremap_resource(dev, res);
- if (IS_ERR(stdev->thermal_base)) {
- dev_err(&pdev->dev, "ioremap failed\n");
+ stdev->thermal_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(stdev->thermal_base))
return PTR_ERR(stdev->thermal_base);
- }
stdev->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(stdev->clk)) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] Thermal: spear: Fix compilation error
2013-05-21 9:20 [PATCH 1/1] Thermal: spear: Fix compilation error Sachin Kamat
@ 2013-05-21 9:35 ` Viresh Kumar
2013-05-23 15:10 ` Eduardo Valentin
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2013-05-21 9:35 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pm, eduardo.valentin, rui.zhang, Vincenzo Frascino
On 21 May 2013 14:50, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes the following compilation error introduced by commit 253e3ae170
> (Thermal: spear_thermal: convert to devm_ioremap_resource).
> drivers/thermal/spear_thermal.c: In function ‘spear_thermal_probe’:
> drivers/thermal/spear_thermal.c:123:46: error: ‘dev’ undeclared
> (first use in this function)
> stdev->thermal_base = devm_ioremap_resource(dev, res);
>
> While at it also remove the error message as devm_ioremap_resource()
> provides its own error messages.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Compile tested and based on linux-next (20130521).
> ---
> drivers/thermal/spear_thermal.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Thermal: spear: Fix compilation error
2013-05-21 9:20 [PATCH 1/1] Thermal: spear: Fix compilation error Sachin Kamat
2013-05-21 9:35 ` Viresh Kumar
@ 2013-05-23 15:10 ` Eduardo Valentin
2013-05-28 2:13 ` Zhang Rui
1 sibling, 1 reply; 4+ messages in thread
From: Eduardo Valentin @ 2013-05-23 15:10 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-pm, eduardo.valentin, rui.zhang, Vincenzo Frascino,
Viresh Kumar
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
On 21-05-2013 05:20, Sachin Kamat wrote:
> Fixes the following compilation error introduced by commit 253e3ae170
> (Thermal: spear_thermal: convert to devm_ioremap_resource).
> drivers/thermal/spear_thermal.c: In function ‘spear_thermal_probe’:
> drivers/thermal/spear_thermal.c:123:46: error: ‘dev’ undeclared
> (first use in this function)
> stdev->thermal_base = devm_ioremap_resource(dev, res);
>
> While at it also remove the error message as devm_ioremap_resource()
> provides its own error messages.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> Compile tested and based on linux-next (20130521).
Also compiled tested on same linux-next.
Tested-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/thermal/spear_thermal.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
> index fa30918..813add6 100644
> --- a/drivers/thermal/spear_thermal.c
> +++ b/drivers/thermal/spear_thermal.c
> @@ -120,11 +120,9 @@ static int spear_thermal_probe(struct platform_device *pdev)
>
> /* Enable thermal sensor */
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - stdev->thermal_base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(stdev->thermal_base)) {
> - dev_err(&pdev->dev, "ioremap failed\n");
> + stdev->thermal_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(stdev->thermal_base))
> return PTR_ERR(stdev->thermal_base);
> - }
>
> stdev->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(stdev->clk)) {
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] Thermal: spear: Fix compilation error
2013-05-23 15:10 ` Eduardo Valentin
@ 2013-05-28 2:13 ` Zhang Rui
0 siblings, 0 replies; 4+ messages in thread
From: Zhang Rui @ 2013-05-28 2:13 UTC (permalink / raw)
To: Eduardo Valentin; +Cc: Sachin Kamat, linux-pm, Vincenzo Frascino, Viresh Kumar
On Thu, 2013-05-23 at 11:10 -0400, Eduardo Valentin wrote:
> On 21-05-2013 05:20, Sachin Kamat wrote:
> > Fixes the following compilation error introduced by commit 253e3ae170
> > (Thermal: spear_thermal: convert to devm_ioremap_resource).
As this commit has not been in upstream yet.
I'll merge these two patches together, instead of two separate patches.
Refreshed patch applied in thermal -next.
thanks,
rui
> > drivers/thermal/spear_thermal.c: In function ‘spear_thermal_probe’:
> > drivers/thermal/spear_thermal.c:123:46: error: ‘dev’ undeclared
> > (first use in this function)
> > stdev->thermal_base = devm_ioremap_resource(dev, res);
> >
> > While at it also remove the error message as devm_ioremap_resource()
> > provides its own error messages.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
>
> Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
>
> > ---
> > Compile tested and based on linux-next (20130521).
>
> Also compiled tested on same linux-next.
>
> Tested-by: Eduardo Valentin <eduardo.valentin@ti.com>
> > ---
> > drivers/thermal/spear_thermal.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
> > index fa30918..813add6 100644
> > --- a/drivers/thermal/spear_thermal.c
> > +++ b/drivers/thermal/spear_thermal.c
> > @@ -120,11 +120,9 @@ static int spear_thermal_probe(struct platform_device *pdev)
> >
> > /* Enable thermal sensor */
> > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - stdev->thermal_base = devm_ioremap_resource(dev, res);
> > - if (IS_ERR(stdev->thermal_base)) {
> > - dev_err(&pdev->dev, "ioremap failed\n");
> > + stdev->thermal_base = devm_ioremap_resource(&pdev->dev, res);
> > + if (IS_ERR(stdev->thermal_base))
> > return PTR_ERR(stdev->thermal_base);
> > - }
> >
> > stdev->clk = devm_clk_get(&pdev->dev, NULL);
> > if (IS_ERR(stdev->clk)) {
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-28 2:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-21 9:20 [PATCH 1/1] Thermal: spear: Fix compilation error Sachin Kamat
2013-05-21 9:35 ` Viresh Kumar
2013-05-23 15:10 ` Eduardo Valentin
2013-05-28 2:13 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).