From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 0/8] ARM: move cpuidle drivers to drivers/cpuidle/ Date: Wed, 26 Jun 2013 15:05:23 +0200 Message-ID: <51CAE713.5070700@linaro.org> References: <1372241747-21083-1-git-send-email-b.zolnierkie@samsung.com> <51CAC9A9.5070906@linaro.org> <5859839.2xKkDrLODE@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-bk0-f47.google.com ([209.85.214.47]:39795 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368Ab3FZNFN (ORCPT ); Wed, 26 Jun 2013 09:05:13 -0400 Received: by mail-bk0-f47.google.com with SMTP id jg1so4872351bkc.20 for ; Wed, 26 Jun 2013 06:05:12 -0700 (PDT) In-Reply-To: <5859839.2xKkDrLODE@amdc1032> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux@maxim.org.za, nicolas.ferre@atmel.com, plagnioj@jcrosoft.com, nsekhar@ti.com, khilman@deeprootsystems.com, kernel@pengutronix.de, shawn.guo@linaro.org, tony@atomide.com, ben-linux@fluff.org, kgene.kim@samsung.com, horms@verge.net.au, magnus.damm@gmail.com, swarren@wwwdotorg.org, srinidhi.kasagar@stericsson.com, linus.walleij@linaro.org, rjw@sisk.pl, kyungmin.park@samsung.com On 06/26/2013 02:22 PM, Bartlomiej Zolnierkiewicz wrote: >=20 > Hi, >=20 > On Wednesday, June 26, 2013 12:59:53 PM Daniel Lezcano wrote: >> On 06/26/2013 12:15 PM, Bartlomiej Zolnierkiewicz wrote: >>> Hi, >>> >>> This patchset moves ARM cpuidle drivers to drivers/cpuidle/ to make >>> code match new driver placement rules (per commit a8e39c3 "cpuidle:= add >>> maintainer entry"). >> >> I second this initiative but as stated in a previous email, a bit of >> code cleanup, consolidation and encapsulation should be done before. >> >> Again, from my POV, it is worth to do that but we have to split the = pm >> code from the driver. >=20 > OK, I'll look into separating the pm code from the drivers. However = it > seems that patch #2 (for davinci) can be applied as it is. No it can't. It still has #include Please have a look at the thread: http://comments.gmane.org/gmane.linux.ports.arm.kernel/146651 >> Please review some patches I sent recently to split this code and >> comment them. Otherwise, we will collide on this work. >> >> All the patches sent [1] was to unify the code to make the drivers a= s >> unified as possible to converge to the same code pattern and to >> facilitate the factoring out. >=20 > I've looked at the patches ([1] and at91 ones) and they look fine to = me. > I don't think that there is currently a risk of colliding on this wor= k > (except at91 case) as your patches (except at91 ones) are already mer= ged > in upstream or linux-next branch of linux-pm tree (which is included = in > linux-next tree which I based my patches on). I'm subscribed to linux= -pm > mailing list now but please cc: me on your future ARM cpuidle changes > (thanks!). We are working on cleaning up the different drivers to have a *common code pattern* in order to factor it out, split the code into pm code an= d driver code, move the drivers to the drivers/cpuidle directory and finally create a single arm driver [1][2][3]. You are sending patches to move the drivers directly to the drivers/cpuidle directory. I did that 1,5 years ago and I was told it i= s not the way to go [4]. As you can see this is a WIP. So I am insisting: that would be better if you sync up with us and chec= k what is the WIP and, if you are willing to, give us a hand instead of doing your way. May I suggest you fix up the exynos cpuidle driver first ? :) Thanks -- Daniel [1] https://blueprints.launchpad.net/linaro-power-kernel/+spec/cpuidle-cons= olidate-arm-drivers [2] http://summit.linuxplumbersconf.org/lpc-2012/meeting/31/lpc2012-ref-cpu= -idle-cluster-management/ [3] https://e.lca-13.zerista.com/event/member/72362 [4] http://comments.gmane.org/gmane.linux.ports.arm.kernel/146651 > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics >=20 >> Thanks >> -- Daniel >> >> [1] >> https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/log= /?h=3Dlinux-next&qt=3Dauthor&q=3Ddaniel.lezcano%40linaro.org >> >>> [ Please note that movement of Samsung EXYNOS cpuidle driver is han= dled >>> in separate patchset since it needs some other changes applied fi= rst. ] >>> >>> Patches are based on linux-next (next-20130624) and are compile tes= ted >>> only. If agreed they all should probably go together through one t= ree >>> (linux-pm or arm-soc) since they all modify drivers/cpuidle/Makefil= e. >>> >>> PS It seems that majority of cpuidle drivers is not used by default >>> (CONFIG_CPU_IDLE is not turned on in corresponding defconfigs). The= only >>> exceptions are shmobile (kota2_defconfig) and tegra (tegra_defconfi= g). >>> This is probably also something that needs updating. >>> >>> Best regards, >>> -- >>> Bartlomiej Zolnierkiewicz >>> Samsung R&D Institute Poland >>> Samsung Electronics >>> >>> >>> Bartlomiej Zolnierkiewicz (8): >>> ARM: at91: move cpuidle driver to drivers/cpuidle/ >>> ARM: davinci: move cpuidle driver to drivers/cpuidle/ >>> ARM: imx: move cpuidle drivers to drivers/cpuidle/ >>> ARM: OMAP: move cpuidle drivers to drivers/cpuidle/ >>> ARM: S3C64XX: move cpuidle driver to drivers/cpuidle/ >>> ARM: shmobile: move cpuidle driver to drivers/cpuidle/ >>> ARM: tegra: move cpuidle drivers to drivers/cpuidle/ >>> ARM: ux500: move cpuidle drivers to drivers/cpuidle/ >>> >>> arch/arm/mach-at91/Makefile | 1 - >>> arch/arm/mach-at91/cpuidle.c | 68 ------- >>> arch/arm/mach-davinci/Makefile | 1 - >>> arch/arm/mach-davinci/cpuidle.c | 105 ---------- >>> arch/arm/mach-imx/Makefile | 5 - >>> arch/arm/mach-imx/cpuidle-imx5.c | 37 ---- >>> arch/arm/mach-imx/cpuidle-imx6q.c | 75 ------- >>> arch/arm/mach-omap2/Makefile | 5 - >>> arch/arm/mach-omap2/cpuidle34xx.c | 344 ---------------------= ------------ >>> arch/arm/mach-omap2/cpuidle44xx.c | 217 --------------------- >>> arch/arm/mach-s3c64xx/Makefile | 1 - >>> arch/arm/mach-s3c64xx/cpuidle.c | 63 ------ >>> arch/arm/mach-shmobile/Makefile | 1 - >>> arch/arm/mach-shmobile/cpuidle.c | 37 ---- >>> arch/arm/mach-tegra/Makefile | 9 - >>> arch/arm/mach-tegra/cpuidle-tegra114.c | 35 ---- >>> arch/arm/mach-tegra/cpuidle-tegra20.c | 217 --------------------- >>> arch/arm/mach-tegra/cpuidle-tegra30.c | 149 -------------- >>> arch/arm/mach-ux500/Makefile | 1 - >>> arch/arm/mach-ux500/cpuidle.c | 128 ------------ >>> drivers/cpuidle/Makefile | 42 ++++ >>> drivers/cpuidle/cpuidle-at91.c | 68 +++++++ >>> drivers/cpuidle/cpuidle-davinci.c | 104 ++++++++++ >>> drivers/cpuidle/cpuidle-imx5.c | 37 ++++ >>> drivers/cpuidle/cpuidle-imx6q.c | 74 +++++++ >>> drivers/cpuidle/cpuidle-omap34xx.c | 342 +++++++++++++++++++++= +++++++++++ >>> drivers/cpuidle/cpuidle-omap44xx.c | 216 +++++++++++++++++++++ >>> drivers/cpuidle/cpuidle-s3c64xx.c | 62 ++++++ >>> drivers/cpuidle/cpuidle-shmobile.c | 37 ++++ >>> drivers/cpuidle/cpuidle-tegra114.c | 35 ++++ >>> drivers/cpuidle/cpuidle-tegra20.c | 217 +++++++++++++++++++++ >>> drivers/cpuidle/cpuidle-tegra30.c | 149 ++++++++++++++ >>> drivers/cpuidle/cpuidle-ux500.c | 128 ++++++++++++ >>> 33 files changed, 1511 insertions(+), 1499 deletions(-) >>> delete mode 100644 arch/arm/mach-at91/cpuidle.c >>> delete mode 100644 arch/arm/mach-davinci/cpuidle.c >>> delete mode 100644 arch/arm/mach-imx/cpuidle-imx5.c >>> delete mode 100644 arch/arm/mach-imx/cpuidle-imx6q.c >>> delete mode 100644 arch/arm/mach-omap2/cpuidle34xx.c >>> delete mode 100644 arch/arm/mach-omap2/cpuidle44xx.c >>> delete mode 100644 arch/arm/mach-s3c64xx/cpuidle.c >>> delete mode 100644 arch/arm/mach-shmobile/cpuidle.c >>> delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra114.c >>> delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra20.c >>> delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra30.c >>> delete mode 100644 arch/arm/mach-ux500/cpuidle.c >>> create mode 100644 drivers/cpuidle/cpuidle-at91.c >>> create mode 100644 drivers/cpuidle/cpuidle-davinci.c >>> create mode 100644 drivers/cpuidle/cpuidle-imx5.c >>> create mode 100644 drivers/cpuidle/cpuidle-imx6q.c >>> create mode 100644 drivers/cpuidle/cpuidle-omap34xx.c >>> create mode 100644 drivers/cpuidle/cpuidle-omap44xx.c >>> create mode 100644 drivers/cpuidle/cpuidle-s3c64xx.c >>> create mode 100644 drivers/cpuidle/cpuidle-shmobile.c >>> create mode 100644 drivers/cpuidle/cpuidle-tegra114.c >>> create mode 100644 drivers/cpuidle/cpuidle-tegra20.c >>> create mode 100644 drivers/cpuidle/cpuidle-tegra30.c >>> create mode 100644 drivers/cpuidle/cpuidle-ux500.c >=20 --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog