From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Lu Subject: Re: [PATCH] block: Fix possible sleep in invalid context Date: Tue, 02 Jul 2013 11:04:22 +0800 Message-ID: <51D24336.5020504@intel.com> References: <1372692515-31969-1-git-send-email-sthumma@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372692515-31969-1-git-send-email-sthumma@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org To: Sujit Reddy Thumma Cc: Jens Axboe , linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, stable@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, 'James Bottomley' , Andrew Morton List-Id: linux-pm@vger.kernel.org On 07/01/2013 11:28 PM, Sujit Reddy Thumma wrote: > When block runtime PM is enabled following warning is seen > while resuming the device. > > BUG: sleeping function called from invalid context at > .../drivers/base/power/runtime.c:923 > in_atomic(): 1, irqs_disabled(): 128, pid: 12, name: kworker/0:1 > [] (unwind_backtrace+0x0/0x120) from > [] (__pm_runtime_suspend+0x34/0xa0) from > [] (blk_post_runtime_resume+0x4c/0x5c) from > [] (scsi_runtime_resume+0x90/0xb4) from > [] (__rpm_callback+0x30/0x58) from > [] (rpm_callback+0x18/0x28) from > [] (rpm_resume+0x3dc/0x540) from > [] (pm_runtime_work+0x8c/0x98) from > [] (process_one_work+0x238/0x3e4) from > [] (worker_thread+0x1ac/0x2ac) from > [] (kthread+0x88/0x94) from > [] (kernel_thread_exit+0x0/0x8) > > Fix this by releasing spin_lock_irq() before calling > pm_runtime_autosuspend() in blk_post_runtime_resume(). Hi Sujit, Thanks for testing out block layer runtime PM! As for the problem here, it is already fixed by: commit c60855cdb976c632b3bf8922eeab8a0e78edfc04 Author: Aaron Lu Date: Fri May 17 15:47:20 2013 +0800 blkpm: avoid sleep when holding queue lock -Aaron > > Signed-off-by: Sujit Reddy Thumma > Cc: stable@vger.kernel.org > --- > block/blk-core.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/block/blk-core.c b/block/blk-core.c > index 33c33bc..2456116 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -3159,16 +3159,18 @@ EXPORT_SYMBOL(blk_pre_runtime_resume); > */ > void blk_post_runtime_resume(struct request_queue *q, int err) > { > - spin_lock_irq(q->queue_lock); > if (!err) { > + spin_lock_irq(q->queue_lock); > q->rpm_status = RPM_ACTIVE; > __blk_run_queue(q); > pm_runtime_mark_last_busy(q->dev); > + spin_unlock_irq(q->queue_lock); > pm_runtime_autosuspend(q->dev); > } else { > + spin_lock_irq(q->queue_lock); > q->rpm_status = RPM_SUSPENDED; > + spin_unlock_irq(q->queue_lock); > } > - spin_unlock_irq(q->queue_lock); > } > EXPORT_SYMBOL(blk_post_runtime_resume); > #endif >