From: Tang Chen <tangchen@cn.fujitsu.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: len.brown@intel.com, pavel@ucw.cz, rjw@sisk.pl,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().
Date: Tue, 23 Jul 2013 15:55:31 +0800 [thread overview]
Message-ID: <51EE36F3.2010308@cn.fujitsu.com> (raw)
In-Reply-To: <20130723073950.GB13710@gmail.com>
On 07/23/2013 03:39 PM, Ingo Molnar wrote:
>
> * Tang Chen<tangchen@cn.fujitsu.com> wrote:
>
>> We wanted to check if the acpi id is out of range. It should be:
>> if (id>= (MAX_LOCAL_APIC)).
>
> Does this have any practical impact, or can it wait until v3.12?
I haven't tested out any impact now, just found it when reading the code.
We can wait until v3.12.
>
>> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com>
>> ---
>> arch/x86/kernel/acpi/boot.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
>> index d81a972..2a15ae7 100644
>> --- a/arch/x86/kernel/acpi/boot.c
>> +++ b/arch/x86/kernel/acpi/boot.c
>> @@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 enabled)
>> {
>> unsigned int ver = 0;
>>
>> - if (id>= (MAX_LOCAL_APIC-1)) {
>> + if (id>= (MAX_LOCAL_APIC)) {
>
> The parentheses are now superfluous.
Oh, yes. I'll send a new version without the parentheses.
Thanks.
prev parent reply other threads:[~2013-07-23 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 1:39 [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic() Tang Chen
2013-07-23 1:38 ` Brown, Len
2013-07-23 7:39 ` Ingo Molnar
2013-07-23 7:55 ` Tang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EE36F3.2010308@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).