From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
kevin.wangtao@linaro.org, leo.yan@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 06/13] thermal/drivers/hisi: Remove pointless lock
Date: Fri, 8 Sep 2017 11:31:00 +0200 [thread overview]
Message-ID: <51bcc9ba-513f-ea7f-6780-6c3c703f63ab@linaro.org> (raw)
In-Reply-To: <20170908031641.GD2755@localhost.localdomain>
On 08/09/2017 05:16, Eduardo Valentin wrote:
> On Mon, Sep 04, 2017 at 09:56:05PM +0200, Daniel Lezcano wrote:
>> The threaded interrupt inspect the sensors structure to look in the temp
>> threshold field, but this field is read-only in all the code, except in the
>> probe function before the threaded interrupt is set. In other words there
>> is not race window in the threaded interrupt when reading the field value.
>
>
> Sure? Not even if you have a userspace process read the zone temp via
> sysfs and the polling workqueue reading the temp too?
They are both read-only operations. There is no write-read race.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-09-08 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 19:56 [PATCH V2 01/13] thermal/drivers/hisi: Fix missing interrupt enablement Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 02/13] thermal/drivers/hisi: Remove the multiple sensors support Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 03/13] thermal/drivers/hisi: Fix kernel panic on alarm interrupt Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 04/13] thermal/drivers/hisi: Simplify the temperature/step computation Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 05/13] thermal/drivers/hisi: Fix multiple alarm interrupts firing Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 06/13] thermal/drivers/hisi: Remove pointless lock Daniel Lezcano
2017-09-08 3:16 ` Eduardo Valentin
2017-09-08 9:31 ` Daniel Lezcano [this message]
2017-09-04 19:56 ` [PATCH V2 07/13] thermal/drivers/hisi: Encapsulate register writes into helpers Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 08/13] thermal/drivers/hisi: Fix configuration register setting Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 09/13] thermal/drivers/hisi: Remove costly sensor inspection Daniel Lezcano
2017-09-08 3:22 ` Eduardo Valentin
2017-09-08 9:50 ` Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 10/13] thermal/drivers/hisi: Rename and remove unused field Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 11/13] thermal/drivers/hisi: Convert long to int Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 12/13] thermal/drivers/hisi: Remove thermal data back pointer Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 13/13] thermal/drivers/hisi: Remove mutex_lock in the code Daniel Lezcano
2017-09-08 3:25 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51bcc9ba-513f-ea7f-6780-6c3c703f63ab@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=kevin.wangtao@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).