From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep KarkadaNagesha Subject: Re: [PATCH v3 05/16] ARM: mvebu: remove device tree parsing for cpu nodes Date: Tue, 06 Aug 2013 10:02:50 +0100 Message-ID: <5200BBBA.7020303@arm.com> References: <1374069984-20567-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1374492747-13879-6-git-send-email-Sudeep.KarkadaNagesha@arm.com> <51FA3064.9080502@arm.com> <20130801120256.GW5882@titan.lakedaemon.net> <51FFD2B1.70509@arm.com> <5200B2E9.8090009@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:57172 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754864Ab3HFJCm convert rfc822-to-8bit (ORCPT ); Tue, 6 Aug 2013 05:02:42 -0400 In-Reply-To: <5200B2E9.8090009@free-electrons.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Gregory CLEMENT Cc: Sudeep KarkadaNagesha , Andrew Lunn , Lorenzo Pieralisi , Russell King , Jason Cooper , Arnd Bergmann , "linux-pm@vger.kernel.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "cpufreq@vger.kernel.org" , "Rafael J. Wysocki" , Olof Johansson , "devicetree@vger.kernel.org" , "rob.herring@calxeda.com" , Viresh Kumar , "grant.likely@linaro.org" , Shawn Guo , "linux-arm-kernel@lists.infradead.org" On 06/08/13 09:25, Gregory CLEMENT wrote: > On 05/08/2013 18:28, Sudeep KarkadaNagesha wrote: >> On 01/08/13 13:02, Jason Cooper wrote: >>> Sudeep, >>> >>> On Thu, Aug 01, 2013 at 10:54:44AM +0100, Sudeep KarkadaNagesha wrote: >>>> On 22/07/13 12:32, Sudeep KarkadaNagesha wrote: >>>>> From: Sudeep KarkadaNagesha >>>>> >>>>> Currently set_secondary_cpus_clock assume the CPU logical ordering >>>>> and the MPDIR in DT are same, which is incorrect. >>>>> >>>>> Since the CPU device nodes can be retrieved in the logical ordering >>>>> using the DT helper, we can remove the devices tree parsing. >>>>> >>>>> This patch removes DT parsing by making use of of_get_cpu_node. >>>>> >>>>> Cc: Gregory Clement >>>>> Cc: Andrew Lunn >>>>> Cc: Jason Cooper >>>>> Signed-off-by: Sudeep KarkadaNagesha >>>> >>>> Hi Gregory/Andrew/Jason, >>>> >>>> Does this change look fine for mvebu? >>>> If yes, can I have your ACKs ? >>> >>> Gregory is the one best suited to review/Ack this. He'll be back on >>> Monday. >>> >> Hi Gregory, >> >> Can you please review this patch ? > > Your patch is a nice improvement, I reviewed it and I also tested it on the > Armada XP DB board. > > You can add my: > Acked-by: Gregory Clement Thanks Gregory. Regards, Sudeep