From: Randy Dunlap <rdunlap@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, pavel@ucw.cz, linaro-kernel@lists.linaro.org,
patches@linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OPP: Export opp_add()
Date: Tue, 06 Aug 2013 05:53:08 -0700 [thread overview]
Message-ID: <5200F1B4.6050004@infradead.org> (raw)
In-Reply-To: <58acb4a8a4e98089078de3ed71999730b6d97b4b.1375521724.git.viresh.kumar@linaro.org>
On 08/03/2013 02:25 AM, Viresh Kumar wrote:
> Export opp_add() so that modules can use it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/base/power/opp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
> index c8ec186..ef89897 100644
> --- a/drivers/base/power/opp.c
> +++ b/drivers/base/power/opp.c
> @@ -460,6 +460,7 @@ int opp_add(struct device *dev, unsigned long freq, unsigned long u_volt)
> srcu_notifier_call_chain(&dev_opp->head, OPP_EVENT_ADD, new_opp);
> return 0;
> }
> +EXPORT_SYMBOL_GPL(opp_add);
Could it be renamed to pm_opp_add() or power_opp_add() ?
The name is a bit too unspecific IMO.
>
> /**
> * opp_set_availability() - helper to set the availability of an opp
>
--
~Randy
next prev parent reply other threads:[~2013-08-06 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 9:25 [PATCH] OPP: Export opp_add() Viresh Kumar
2013-08-05 12:29 ` Nishanth Menon
2013-08-05 12:47 ` Rafael J. Wysocki
2013-08-06 4:48 ` Viresh Kumar
2013-08-06 12:53 ` Randy Dunlap [this message]
2013-08-06 13:08 ` OPP: rename functions? (was [PATCH] OPP: Export opp_add()) Nishanth Menon
2013-08-06 14:15 ` Rafael J. Wysocki
2013-08-07 15:48 ` Nishanth Menon
2013-08-07 22:53 ` Rafael J. Wysocki
2013-08-08 12:00 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5200F1B4.6050004@infradead.org \
--to=rdunlap@infradead.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).