[RESEND][PATCH 1/2] PM / devfreq: exynos-ppmu: ppmu_events array should not be NULL terminated

[RESEND][PATCH 1/2] PM / devfreq: exynos-ppmu: ppmu_events array should not be NULL terminated

[Axel Lin]

The rest of the code uses ARRAY_SIZE to count the number of entries in
ppmu_events array. The NULL terminated entry makes ARRAY_SIZE return
off-by-one value.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
---
This patch was sent on https://patchwork.kernel.org/patch/9342637/
 drivers/devfreq/event/exynos-ppmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index f55cf0e..c9ffaf0 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -90,8 +90,6 @@ struct __exynos_ppmu_events {
 	PPMU_EVENT(d1-cpu),
 	PPMU_EVENT(d1-general),
 	PPMU_EVENT(d1-rt),
-
-	{ /* sentinel */ },
 };
 
 static int exynos_ppmu_find_ppmu_id(struct devfreq_event_dev *edev)
-- 
2.7.4

[RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu

[Axel Lin]

The mutex is not used at all, remove it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
---
This patch was sent on https://patchwork.kernel.org/patch/9341097/
 drivers/devfreq/event/exynos-ppmu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index f55cf0e..251692b 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -15,7 +15,6 @@
 #include <linux/io.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/mutex.h>
 #include <linux/of_address.h>
 #include <linux/platform_device.h>
 #include <linux/suspend.h>
@@ -34,7 +33,6 @@ struct exynos_ppmu {
 	unsigned int num_events;
 
 	struct device *dev;
-	struct mutex lock;
 
 	struct exynos_ppmu_data ppmu;
 };
@@ -463,7 +461,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
 	if (!info)
 		return -ENOMEM;
 
-	mutex_init(&info->lock);
 	info->dev = &pdev->dev;
 
 	/* Parse dt data to get resource */
-- 
2.7.4

RE: [RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu

[MyungJoo Ham]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

> --------- Original Message ---------
> Sender : Axel Lin <axel.lin@ingics.com>
> Date : 2016-10-21 10:09 (GMT+9)
> Title : [RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu
>  
> The mutex is not used at all, remove it.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Both patches are stacked in for-4.9-rc branch.


Thanks.

Cheers,
MyungJoo

> ---
> 
> This patch was sent on https://patchwork.kernel.org/patch/9341097/
>  drivers/devfreq/event/exynos-ppmu.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
>