From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepthi Dharwar Subject: Re: [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for powernv and pseries. Date: Mon, 19 Aug 2013 10:13:31 +0530 Message-ID: <5211A273.1080903@linux.vnet.ibm.com> References: <20130731025840.19448.24468.stgit@deepthi> <20130731025934.19448.16658.stgit@deepthi> <1375830520.5600.23.camel@snotra.buserror.net> <1375831851.12557.74.camel@pasglop> <1375832471.5600.41.camel@snotra.buserror.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e28smtp01.in.ibm.com ([122.248.162.1]:37678 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774Ab3HSEoQ (ORCPT ); Mon, 19 Aug 2013 00:44:16 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Aug 2013 10:05:25 +0530 In-Reply-To: <1375832471.5600.41.camel@snotra.buserror.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Scott Wood Cc: Benjamin Herrenschmidt , linux-pm@vger.kernel.org, daniel.lezcano@linaro.org, rjw@sisk.pl, linux-kernel@vger.kernel.org, dongsheng.wang@freescale.com, srivatsa.bhat@linux.vnet.ibm.com, preeti@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org On 08/07/2013 05:11 AM, Scott Wood wrote: > On Wed, 2013-08-07 at 09:30 +1000, Benjamin Herrenschmidt wrote: >> On Tue, 2013-08-06 at 18:08 -0500, Scott Wood wrote: >>> Here's another example. get_lppaca() will only build on book3s -- and >>> yet we get requests for e500 code to use this file. >> >> Indeed, Besides there is already accessors afaik for lppaca that compile >> to nothing on E (and if not they would be trivial to add). > > I don't see such an accessor, but if there were, what would happen when > the caller goes on to dereference that nothing? > > There is an accessor for shared_proc specifically (in the spinlock code) > -- not that it would be much help on booke to just compile away that > check and always select one of the pseries state tables over the other. > > -Scott Thanks a lot Scott and Ben for the review. I have addressed the issues in V3 of this patch series which I have just posted out. Regards, Deepthi > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev > >