linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/3] intel_idle: mark some functions with __init tag
@ 2013-08-30 10:27 Bartlomiej Zolnierkiewicz
  2013-09-02  9:29 ` Daniel Lezcano
  0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-08-30 10:27 UTC (permalink / raw)
  To: Len Brown; +Cc: Daniel Lezcano, Rafael J. Wysocki, linux-pm, linux-kernel

intel_idle_probe() and intel_idle_cpuidle_driver_init() can be marked
with __init tag as they are only called from intel_idle_init().

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Len Brown <lenb@kernel.org>
---
 drivers/idle/intel_idle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 53b24f1..33e599e 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -490,7 +490,7 @@ MODULE_DEVICE_TABLE(x86cpu, intel_idle_ids);
 /*
  * intel_idle_probe()
  */
-static int intel_idle_probe(void)
+static int __init intel_idle_probe(void)
 {
 	unsigned int eax, ebx, ecx;
 	const struct x86_cpu_id *id;
@@ -558,7 +558,7 @@ static void intel_idle_cpuidle_devices_uninit(void)
  * intel_idle_cpuidle_driver_init()
  * allocate, initialize cpuidle_states
  */
-static int intel_idle_cpuidle_driver_init(void)
+static int __init intel_idle_cpuidle_driver_init(void)
 {
 	int cstate;
 	struct cpuidle_driver *drv = &intel_idle_driver;
-- 
1.8.2.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] intel_idle: mark some functions with __init tag
  2013-08-30 10:27 [PATCH 3/3] intel_idle: mark some functions with __init tag Bartlomiej Zolnierkiewicz
@ 2013-09-02  9:29 ` Daniel Lezcano
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2013-09-02  9:29 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz
  Cc: Len Brown, Rafael J. Wysocki, linux-pm, linux-kernel

On 08/30/2013 12:27 PM, Bartlomiej Zolnierkiewicz wrote:
> intel_idle_probe() and intel_idle_cpuidle_driver_init() can be marked
> with __init tag as they are only called from intel_idle_init().
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Len Brown <lenb@kernel.org>
> ---

Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>


>  drivers/idle/intel_idle.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 53b24f1..33e599e 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -490,7 +490,7 @@ MODULE_DEVICE_TABLE(x86cpu, intel_idle_ids);
>  /*
>   * intel_idle_probe()
>   */
> -static int intel_idle_probe(void)
> +static int __init intel_idle_probe(void)
>  {
>  	unsigned int eax, ebx, ecx;
>  	const struct x86_cpu_id *id;
> @@ -558,7 +558,7 @@ static void intel_idle_cpuidle_devices_uninit(void)
>   * intel_idle_cpuidle_driver_init()
>   * allocate, initialize cpuidle_states
>   */
> -static int intel_idle_cpuidle_driver_init(void)
> +static int __init intel_idle_cpuidle_driver_init(void)
>  {
>  	int cstate;
>  	struct cpuidle_driver *drv = &intel_idle_driver;

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-02  9:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-30 10:27 [PATCH 3/3] intel_idle: mark some functions with __init tag Bartlomiej Zolnierkiewicz
2013-09-02  9:29 ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).