From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, swarren@wwwdotorg.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] cpufreq: don't break string in print statements
Date: Thu, 12 Sep 2013 13:41:13 +0530 [thread overview]
Message-ID: <52317721.9050407@linux.vnet.ibm.com> (raw)
In-Reply-To: <e086b55f2ec5c7a67fa28a21f23c088b67e5191e.1378963070.git.viresh.kumar@linaro.org>
On 09/12/2013 10:55 AM, Viresh Kumar wrote:
> As a rule its better not to break string (quoted inside "") in a print statement
> even if it crosses 80 column boundary as that may introduce unwanted bugs and so
> this patch rewrites one of the print statements..
>
Ok, if that is the convention, then so be it.
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
> ---
> drivers/cpufreq/cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 28477eb..31f7845 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1192,8 +1192,8 @@ static int __cpufreq_remove_dev_prepare(struct device *dev,
> unlock_policy_rwsem_write(cpu);
>
> if (!frozen) {
> - pr_debug("%s: policy Kobject moved to cpu: %d "
> - "from: %d\n",__func__, new_cpu, cpu);
> + pr_debug("%s: policy Kobject moved to cpu: %d from: %d\n",
> + __func__, new_cpu, cpu);
> }
> }
> }
>
next prev parent reply other threads:[~2013-09-12 8:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 5:25 [PATCH 0/5] cpufreq: Last minute fixes for 3.12 Viresh Kumar
2013-09-12 5:25 ` [PATCH 1/5] cpufreq: Remove extra blank line Viresh Kumar
2013-09-12 8:16 ` Srivatsa S. Bhat
2013-09-12 10:08 ` Viresh Kumar
2013-09-12 5:25 ` [PATCH 2/5] cpufreq: don't break string in print statements Viresh Kumar
2013-09-12 8:11 ` Srivatsa S. Bhat [this message]
2013-09-12 5:25 ` [PATCH 3/5] cpufreq: remove __cpufreq_remove_dev() Viresh Kumar
2013-09-12 8:09 ` Srivatsa S. Bhat
2013-09-12 5:25 ` [PATCH 4/5] cpufreq: don't update policy->cpu while removing while removing other CPUs Viresh Kumar
2013-09-12 8:13 ` Srivatsa S. Bhat
2013-09-12 5:25 ` [PATCH 5/5] cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish() Viresh Kumar
2013-09-12 6:40 ` Srivatsa S. Bhat
2013-09-12 6:47 ` Viresh Kumar
2013-09-12 6:56 ` Viresh Kumar
2013-09-12 7:16 ` Srivatsa S. Bhat
2013-09-12 9:21 ` Viresh Kumar
2013-09-12 10:47 ` Rafael J. Wysocki
2013-09-12 10:43 ` Viresh Kumar
2013-09-12 10:56 ` Rafael J. Wysocki
2013-09-12 10:49 ` Viresh Kumar
2013-09-12 18:08 ` Stephen Warren
2013-09-17 15:20 ` Stephen Warren
2013-09-17 16:18 ` Viresh Kumar
2013-09-17 18:43 ` Rafael J. Wysocki
2013-09-18 4:31 ` Viresh Kumar
2013-09-12 10:05 ` [PATCH 0/5] cpufreq: Last minute fixes for 3.12 Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52317721.9050407@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=swarren@wwwdotorg.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).