From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
gregkh@linuxfoundation.org, len.brown@intel.com, rjw@sisk.pl,
arjan@linux.intel.com, jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v1 5/6] bitops: Introduce BIT_ULL
Date: Thu, 19 Sep 2013 10:07:35 -0700 [thread overview]
Message-ID: <523B2F57.2050504@linux.intel.com> (raw)
In-Reply-To: <20130919164830.GB9427@pd.tnic>
On 09/19/2013 09:48 AM, Borislav Petkov wrote:
> On Thu, Sep 19, 2013 at 09:00:34AM -0700, Srinivas Pandruvada wrote:
>> Adding BIT(x) equivalent for unsigned long long type, BIT_ULL(x).
>>
>> Suggested-by: Joe Perches <joe@perches.com>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
>> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> ---
>> include/linux/bitops.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
>> index a3b6b82..34e9e94 100644
>> --- a/include/linux/bitops.h
>> +++ b/include/linux/bitops.h
>> @@ -4,6 +4,7 @@
>>
>> #ifdef __KERNEL__
>> #define BIT(nr) (1UL << (nr))
>> +#define BIT_ULL(nr) (1ULL << (nr))
> We already have BIT_64 for that.
>
The current definition for BIT_64 is in arch/x86/include/asm/bitops.h. I
feel it should be applicable for all architectures and move to some
common file.
Thanks,
Srinivas
next prev parent reply other threads:[~2013-09-19 16:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 16:00 [PATCH v1 0/6] Power Capping Framework and RAPL Driver Srinivas Pandruvada
2013-09-19 16:00 ` [PATCH v1 1/6] PowerCap: Documentation Srinivas Pandruvada
2013-09-19 16:00 ` [PATCH v1 2/6] PowerCap: Add class driver Srinivas Pandruvada
2013-09-19 16:00 ` [PATCH v1 3/6] PowerCap: Added to drivers build Srinivas Pandruvada
2013-09-19 16:00 ` [PATCH v1 4/6] x86/msr: add 64bit _on_cpu access functions Srinivas Pandruvada
2013-09-19 16:00 ` [PATCH v1 5/6] bitops: Introduce BIT_ULL Srinivas Pandruvada
2013-09-19 16:48 ` Borislav Petkov
2013-09-19 17:07 ` Srinivas Pandruvada [this message]
2013-09-19 17:28 ` Borislav Petkov
2013-09-19 18:14 ` Joe Perches
2013-09-19 18:34 ` Srinivas Pandruvada
2013-09-19 18:34 ` Joe Perches
2013-09-19 18:48 ` Borislav Petkov
2013-09-19 16:00 ` [PATCH v1 6/6] Introduce Intel RAPL power capping driver Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B2F57.2050504@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).