From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Pandruvada Subject: Re: [PATCH v1 5/6] bitops: Introduce BIT_ULL Date: Thu, 19 Sep 2013 10:07:35 -0700 Message-ID: <523B2F57.2050504@linux.intel.com> References: <1379606435-15871-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1379606435-15871-6-git-send-email-srinivas.pandruvada@linux.intel.com> <20130919164830.GB9427@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:14732 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689Ab3ISQ7T (ORCPT ); Thu, 19 Sep 2013 12:59:19 -0400 In-Reply-To: <20130919164830.GB9427@pd.tnic> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, len.brown@intel.com, rjw@sisk.pl, arjan@linux.intel.com, jacob.jun.pan@linux.intel.com On 09/19/2013 09:48 AM, Borislav Petkov wrote: > On Thu, Sep 19, 2013 at 09:00:34AM -0700, Srinivas Pandruvada wrote: >> Adding BIT(x) equivalent for unsigned long long type, BIT_ULL(x). >> >> Suggested-by: Joe Perches >> Signed-off-by: Srinivas Pandruvada >> Signed-off-by: Jacob Pan >> Acked-by: Rafael J. Wysocki >> --- >> include/linux/bitops.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/bitops.h b/include/linux/bitops.h >> index a3b6b82..34e9e94 100644 >> --- a/include/linux/bitops.h >> +++ b/include/linux/bitops.h >> @@ -4,6 +4,7 @@ >> >> #ifdef __KERNEL__ >> #define BIT(nr) (1UL << (nr)) >> +#define BIT_ULL(nr) (1ULL << (nr)) > We already have BIT_64 for that. > The current definition for BIT_64 is in arch/x86/include/asm/bitops.h. I feel it should be applicable for all architectures and move to some common file. Thanks, Srinivas