From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>, rjw@sisk.pl
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/21] cpuidle: call cpuidle_get_driver() from after taking cpuidle_driver_lock
Date: Thu, 26 Sep 2013 00:04:39 +0200 [thread overview]
Message-ID: <52435DF7.8040307@linaro.org> (raw)
In-Reply-To: <193825f6c2fb70462f6da2cc60e7c6c02682d6c5.1379779777.git.viresh.kumar@linaro.org>
On 09/22/2013 03:21 AM, Viresh Kumar wrote:
> cpuidle_driver_lock is taken correctly at most of the places but at few places
> calls to cpuidle_get_driver() are done from outside of this lock.
>
> Fix them by calling cpuidle_get_driver() after taking cpuidle_driver_lock.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/cpuidle/driver.c | 3 ++-
> drivers/cpuidle/sysfs.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
> index 6279e1c..7b2510a 100644
> --- a/drivers/cpuidle/driver.c
> +++ b/drivers/cpuidle/driver.c
> @@ -340,10 +340,11 @@ struct cpuidle_driver *cpuidle_driver_ref(void)
> */
> void cpuidle_driver_unref(void)
> {
> - struct cpuidle_driver *drv = cpuidle_get_driver();
> + struct cpuidle_driver *drv;
>
> spin_lock(&cpuidle_driver_lock);
>
> + drv = cpuidle_get_driver();
> if (drv && !WARN_ON(drv->refcnt <= 0))
> drv->refcnt--;
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index 8739cc0..a022393 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -52,9 +52,10 @@ static ssize_t show_current_driver(struct device *dev,
> char *buf)
> {
> ssize_t ret;
> - struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();
> + struct cpuidle_driver *cpuidle_driver;
>
> spin_lock(&cpuidle_driver_lock);
> + cpuidle_driver = cpuidle_get_driver();
> if (cpuidle_driver)
> ret = sprintf(buf, "%s\n", cpuidle_driver->name);
> else
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-09-25 22:04 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 1:20 [PATCH 00/21] CPUIdle: Minor cleanups for 3.13 Viresh Kumar
2013-09-22 1:20 ` [PATCH 01/21] cpuidle: fix indentation of cpumask Viresh Kumar
2013-09-22 1:20 ` [PATCH 02/21] cpuidle: Fix comments in cpuidle core Viresh Kumar
2013-09-22 1:20 ` [PATCH 03/21] cpuidle: make __cpuidle_get_cpu_driver() inline Viresh Kumar
2013-09-25 21:27 ` Daniel Lezcano
2013-09-22 1:20 ` [PATCH 04/21] cpuidle: make __cpuidle_device_init() return void Viresh Kumar
2013-09-22 1:20 ` [PATCH 05/21] cpuidle: make __cpuidle_driver_init() " Viresh Kumar
2013-09-23 9:58 ` Hongbo Zhang
2013-09-23 10:02 ` Viresh Kumar
2013-09-22 1:20 ` [PATCH 06/21] cpuidle: rearrange code in __cpuidle_driver_init() Viresh Kumar
2013-09-25 21:40 ` Daniel Lezcano
2013-09-26 5:01 ` Viresh Kumar
2013-09-22 1:20 ` [PATCH 07/21] cpuidle: rearrange __cpuidle_register_device() to keep minimal exit points Viresh Kumar
2013-09-25 21:49 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 08/21] cpuidle: use cpuidle_disabled() instead of "off" Viresh Kumar
2013-09-25 21:52 ` Daniel Lezcano
2013-09-26 5:06 ` Viresh Kumar
2013-09-26 8:25 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 09/21] cpuidle: merge two if() statements for checking error cases Viresh Kumar
2013-09-25 21:52 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 10/21] cpuidle: reduce code duplication inside cpuidle_idle_call() Viresh Kumar
2013-09-25 22:01 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 11/21] cpuidle: replace multiline statements with single line in cpuidle_idle_call() Viresh Kumar
2013-09-25 22:03 ` Daniel Lezcano
2013-09-26 5:51 ` Viresh Kumar
2013-09-26 7:55 ` Daniel Lezcano
2013-09-26 8:11 ` Viresh Kumar
2013-09-22 1:21 ` [PATCH 12/21] cpuidle: call cpuidle_get_driver() from after taking cpuidle_driver_lock Viresh Kumar
2013-09-25 22:04 ` Daniel Lezcano [this message]
2013-09-22 1:21 ` [PATCH 13/21] cpuidle: use drv instead of cpuidle_driver in show_current_driver() Viresh Kumar
2013-09-25 22:05 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 14/21] cpuidle: coupled: don't compare cpu masks unnecessarily Viresh Kumar
2013-09-25 22:06 ` Daniel Lezcano
2013-09-26 0:25 ` Colin Cross
2013-09-26 6:36 ` Viresh Kumar
2013-09-26 6:50 ` Colin Cross
2013-09-22 1:21 ` [PATCH 15/21] cpuidle: free all state kobjects from cpuidle_free_state_kobj() Viresh Kumar
2013-09-25 22:09 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 16/21] cpuidle: avoid unnecessary kzalloc/free of struct cpuidle_device_kobj Viresh Kumar
2013-09-25 22:12 ` Daniel Lezcano
2013-09-26 6:05 ` Viresh Kumar
2013-09-26 8:30 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 17/21] cpuidle: avoid unnecessary kzalloc/free of struct cpuidle_driver_kobj Viresh Kumar
2013-09-25 22:16 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 18/21] cpuidle: don't call poll_idle_init() for every cpu Viresh Kumar
2013-09-25 22:22 ` Daniel Lezcano
2013-09-26 6:09 ` Viresh Kumar
2013-09-26 8:28 ` Daniel Lezcano
2013-10-03 10:33 ` Viresh Kumar
2013-10-03 11:46 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 19/21] cpuidle: create list of registered drivers Viresh Kumar
2013-09-25 22:30 ` Daniel Lezcano
2013-09-26 6:17 ` Viresh Kumar
2013-09-26 8:19 ` Daniel Lezcano
2013-09-28 21:33 ` Paul E. McKenney
2013-09-30 18:37 ` Daniel Lezcano
2013-10-03 4:38 ` Viresh Kumar
2013-10-03 10:47 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 20/21] cpuidle: don't calculate time-diff if entered_state == 0 Viresh Kumar
2013-09-25 22:38 ` Daniel Lezcano
2013-09-26 6:24 ` Viresh Kumar
2013-09-26 8:25 ` Daniel Lezcano
2013-09-26 8:28 ` Viresh Kumar
2013-09-26 8:33 ` Daniel Lezcano
2013-09-22 1:21 ` [PATCH 21/21] cpuidle: change governor from within cpuidle_replace_governor() Viresh Kumar
2013-09-25 22:50 ` Daniel Lezcano
2013-09-26 6:37 ` Viresh Kumar
2013-09-26 8:20 ` Daniel Lezcano
2013-10-03 10:36 ` Viresh Kumar
2013-10-03 11:58 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52435DF7.8040307@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).