linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: rjw@sisk.pl, linux-pm@vger.kernel.org, kyungmin.park@samsung.com
Subject: Re: [PATCH 0/9] cpuidle: rework device state count handling
Date: Thu, 26 Sep 2013 12:40:17 +0200	[thread overview]
Message-ID: <52440F11.8010706@linaro.org> (raw)
In-Reply-To: <98588621.30oeP6cEfZ@amdc1032>

On 09/23/2013 06:05 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Daniel,
>
> Did you have a chance to take a look at this patchset?
>
> Could it be queued for 3.13 (unfortunately it is probably too late for 3.12)?

Thanks for the head up, I will review it.

Unfortunately this patchset did not get any acked-by from the different 
maintainers. Furthermore I believe it would be up to Rafael to take them.

   -- Daniel

> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
> On Tuesday, August 20, 2013 04:23:38 PM Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> Some cpuidle drivers assume that cpuidle core will handle cases where
>> device->state_count is smaller than driver->state_count, unfortunately
>> currently this is untrue (device->state_count is used only for handling
>> cpuidle state sysfs entries and driver->state_count is used for all
>> other cases) and will not be fixed in the future as device->state_count
>> is planned to be removed [1].
>>
>> This patchset fixes such drivers (ARM EXYNOS cpuidle driver and ACPI
>> cpuidle driver), removes superflous device->state_count initialization
>> from drivers for which device->state_count equals driver->state_count
>> (POWERPC pseries cpuidle driver and intel_idle driver) and finally
>> removes state_count field from struct cpuidle_device.
>>
>> Additionaly (while at it) this patchset fixes C1E promotion disable
>> quirk handling (in intel_idle driver) and converts cpuidle drivers code
>> to use the common cpuidle_[un]register() routines (in POWERPC pseries
>> cpuidle driver and intel_idle driver).
>>
>> [1] http://permalink.gmane.org/gmane.linux.power-management.general/36908
>>
>> Best regards,
>> --
>> Bartlomiej Zolnierkiewicz
>> Samsung R&D Institute Poland
>> Samsung Electronics
>>
>>
>> Bartlomiej Zolnierkiewicz (9):
>>    ARM: EXYNOS: cpuidle: fix AFTR mode check
>>    POWERPC: pseries: cpuidle: remove superfluous dev->state_count
>>      initialization
>>    POWERPC: pseries: cpuidle: use the common cpuidle_[un]register()
>>      routines
>>    ACPI / cpuidle: fix max idle state handling with hotplug CPU support
>>    ACPI / cpuidle: remove dev->state_count setting
>>    intel_idle: do C1E promotion disable quirk for hotplugged CPUs
>>    intel_idle: remove superfluous dev->state_count initialization
>>    intel_idle: use the common cpuidle_[un]register() routines
>>    cpuidle: remove state_count field from struct cpuidle_device
>>
>>   arch/arm/mach-exynos/cpuidle.c                  |   8 +-
>>   arch/powerpc/platforms/pseries/processor_idle.c |  59 +---------
>>   drivers/acpi/processor_idle.c                   |  29 +++--
>>   drivers/cpuidle/cpuidle.c                       |   3 -
>>   drivers/cpuidle/sysfs.c                         |   5 +-
>>   drivers/idle/intel_idle.c                       | 140 +++++-------------------
>>   include/linux/cpuidle.h                         |   1 -
>>   7 files changed, 51 insertions(+), 194 deletions(-)
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2013-09-26 10:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20 14:23 [PATCH 0/9] cpuidle: rework device state count handling Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 1/9] ARM: EXYNOS: cpuidle: fix AFTR mode check Bartlomiej Zolnierkiewicz
2013-09-26 10:42   ` Daniel Lezcano
2013-08-20 14:23 ` [PATCH 2/9] POWERPC: pseries: cpuidle: remove superfluous dev->state_count initialization Bartlomiej Zolnierkiewicz
2013-09-26 10:45   ` Daniel Lezcano
2013-08-20 14:23 ` [PATCH 3/9] POWERPC: pseries: cpuidle: use the common cpuidle_[un]register() routines Bartlomiej Zolnierkiewicz
2013-09-26 10:47   ` Daniel Lezcano
2013-08-20 14:23 ` [PATCH 4/9] ACPI / cpuidle: fix max idle state handling with hotplug CPU support Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 5/9] ACPI / cpuidle: remove dev->state_count setting Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 6/9] intel_idle: do C1E promotion disable quirk for hotplugged CPUs Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 7/9] intel_idle: remove superfluous dev->state_count initialization Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 8/9] intel_idle: use the common cpuidle_[un]register() routines Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 9/9] cpuidle: remove state_count field from struct cpuidle_device Bartlomiej Zolnierkiewicz
2013-09-23 16:05 ` [PATCH 0/9] cpuidle: rework device state count handling Bartlomiej Zolnierkiewicz
2013-09-26 10:40   ` Daniel Lezcano [this message]
2013-09-27  1:04     ` Rafael J. Wysocki
2013-11-04 14:28       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52440F11.8010706@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).