From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: rjw@sisk.pl, linux-pm@vger.kernel.org, kyungmin.park@samsung.com,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/9] POWERPC: pseries: cpuidle: remove superfluous dev->state_count initialization
Date: Thu, 26 Sep 2013 12:45:53 +0200 [thread overview]
Message-ID: <52441061.8090704@linaro.org> (raw)
In-Reply-To: <1377008627-32691-3-git-send-email-b.zolnierkie@samsung.com>
On 08/20/2013 04:23 PM, Bartlomiej Zolnierkiewicz wrote:
> pseries cpuidle driver sets dev->state_count to drv->state_count so
> the default dev->state_count initialization in cpuidle_enable_device()
> (called from cpuidle_register_device()) can be used instead.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/powerpc/platforms/pseries/processor_idle.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pseries/processor_idle.c b/arch/powerpc/platforms/pseries/processor_idle.c
> index 14899b1..23fc091 100644
> --- a/arch/powerpc/platforms/pseries/processor_idle.c
> +++ b/arch/powerpc/platforms/pseries/processor_idle.c
> @@ -273,7 +273,6 @@ static void pseries_idle_devices_uninit(void)
> static int pseries_idle_devices_init(void)
> {
> int i;
> - struct cpuidle_driver *drv = &pseries_idle_driver;
> struct cpuidle_device *dev;
>
> pseries_cpuidle_devices = alloc_percpu(struct cpuidle_device);
> @@ -282,7 +281,6 @@ static int pseries_idle_devices_init(void)
>
> for_each_possible_cpu(i) {
> dev = per_cpu_ptr(pseries_cpuidle_devices, i);
> - dev->state_count = drv->state_count;
> dev->cpu = i;
> if (cpuidle_register_device(dev)) {
> printk(KERN_DEBUG \
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-09-26 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 14:23 [PATCH 0/9] cpuidle: rework device state count handling Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 1/9] ARM: EXYNOS: cpuidle: fix AFTR mode check Bartlomiej Zolnierkiewicz
2013-09-26 10:42 ` Daniel Lezcano
2013-08-20 14:23 ` [PATCH 2/9] POWERPC: pseries: cpuidle: remove superfluous dev->state_count initialization Bartlomiej Zolnierkiewicz
2013-09-26 10:45 ` Daniel Lezcano [this message]
2013-08-20 14:23 ` [PATCH 3/9] POWERPC: pseries: cpuidle: use the common cpuidle_[un]register() routines Bartlomiej Zolnierkiewicz
2013-09-26 10:47 ` Daniel Lezcano
2013-08-20 14:23 ` [PATCH 4/9] ACPI / cpuidle: fix max idle state handling with hotplug CPU support Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 5/9] ACPI / cpuidle: remove dev->state_count setting Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 6/9] intel_idle: do C1E promotion disable quirk for hotplugged CPUs Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 7/9] intel_idle: remove superfluous dev->state_count initialization Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 8/9] intel_idle: use the common cpuidle_[un]register() routines Bartlomiej Zolnierkiewicz
2013-08-20 14:23 ` [PATCH 9/9] cpuidle: remove state_count field from struct cpuidle_device Bartlomiej Zolnierkiewicz
2013-09-23 16:05 ` [PATCH 0/9] cpuidle: rework device state count handling Bartlomiej Zolnierkiewicz
2013-09-26 10:40 ` Daniel Lezcano
2013-09-27 1:04 ` Rafael J. Wysocki
2013-11-04 14:28 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52441061.8090704@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=deepthi@linux.vnet.ibm.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).