Re: [RFC PATCH] ARM: zynq: cpuidle: convert to platform driver

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 09/27/2013 07:12 AM, Michal Simek wrote:
> Hi Daniel,
>
> On 09/26/2013 06:15 PM, Daniel Lezcano wrote:
>> As the ux500 and the kirkwood driver, make the zynq driver a platform driver
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>>   arch/arm/mach-zynq/common.c    |    7 +++++++
>>   drivers/cpuidle/cpuidle-zynq.c |   15 ++++++++++-----
>>   2 files changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
>> index 5f25256..0f0d88f 100644
>> --- a/arch/arm/mach-zynq/common.c
>> +++ b/arch/arm/mach-zynq/common.c
>> @@ -44,6 +44,10 @@ static struct of_device_id zynq_of_bus_ids[] __initdata = {
>>   	{}
>>   };
>>
>> +static struct platform_device zynq_cpuidle_device = {
>> +	.name = "cpuidle-zynq",
>> +};
>> +
>>   /**
>>    * zynq_init_machine - System specific initialization, intended to be
>>    *		       called from board specific initialization.
>> @@ -56,6 +60,9 @@ static void __init zynq_init_machine(void)
>>   	l2x0_of_init(0x02060000, 0xF0F0FFFF);
>>
>>   	of_platform_bus_probe(NULL, zynq_of_bus_ids, NULL);
>> +
>> +	if (of_machine_is_compatible("xlnx,zynq-7000"))
>
> This is not needed because all zynq platforms have this compatibility string
> and there is no any other clone.

Ah, ok. So it is not needed in the current code. I will write its 
removal in a separate patch.

Thanks
   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog