From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Srivatsa S. Bhat" Subject: Re: [PATCH RESEND 09/11] cpufreq: rewrite cpufreq_driver->flags using shift operator Date: Thu, 03 Oct 2013 13:02:45 +0530 Message-ID: <524D1D9D.9080908@linux.vnet.ibm.com> References: <7b34bf61846bed19e4a7e8ee18a55e717c570fef.1380703248.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e28smtp03.in.ibm.com ([122.248.162.3]:41608 "EHLO e28smtp03.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274Ab3JCHg5 (ORCPT ); Thu, 3 Oct 2013 03:36:57 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Oct 2013 13:06:54 +0530 In-Reply-To: <7b34bf61846bed19e4a7e8ee18a55e717c570fef.1380703248.git.viresh.kumar@linaro.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: rjw@sisk.pl, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" On 10/02/2013 02:13 PM, Viresh Kumar wrote: > Currently cpufreq_driver's flags are defined directly using 0x1, 0x2, 0x4, 0x8, > etc.. As the list grows it doesn't stays much readable.. > > Lets use bitwise shift operator << to generate these numbers for respective > positions. > > Signed-off-by: Viresh Kumar > --- Reviewed-by: Srivatsa S. Bhat Regards, Srivatsa S. Bhat > include/linux/cpufreq.h | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index a72bac2..9321059 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -225,13 +225,14 @@ struct cpufreq_driver { > }; > > /* flags */ > -#define CPUFREQ_STICKY 0x01 /* the driver isn't removed even if > - * all ->init() calls failed */ > -#define CPUFREQ_CONST_LOOPS 0x02 /* loops_per_jiffy or other kernel > - * "constants" aren't affected by > - * frequency transitions */ > -#define CPUFREQ_PM_NO_WARN 0x04 /* don't warn on suspend/resume speed > - * mismatches */ > +#define CPUFREQ_STICKY (1 << 0) /* driver isn't removed even if > + all ->init() calls failed */ > +#define CPUFREQ_CONST_LOOPS (1 << 1) /* loops_per_jiffy or other > + kernel "constants" aren't > + affected by frequency > + transitions */ > +#define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume > + speed mismatches */ > > int cpufreq_register_driver(struct cpufreq_driver *driver_data); > int cpufreq_unregister_driver(struct cpufreq_driver *driver_data); >