From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] thermal: offer TI thermal support only when ARCH_OMAP2PLUS is defined
Date: Fri, 4 Oct 2013 14:26:54 -0400 [thread overview]
Message-ID: <524F086E.4020608@ti.com> (raw)
In-Reply-To: <524F0766.8070302@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]
On 04-10-2013 14:22, Eduardo Valentin wrote:
> On 04-10-2013 08:35, Bartlomiej Zolnierkiewicz wrote:
>> Menu for Texas Instruments thermal support is visible on all
>> platforms and TI_SOC_THERMAL + TI_THERMAL config options can
>> be selected also on EXYNOS platform (on which ARCH_HAS_BANDGAP
>> config option is selected by SoCs config options to fulfill
>> EXYNOS_THERMAL config option dependency). Thus the code which
>> is never used can be build. Fix it by making TI menu dependent
>> on ARCH_OMAP2PLUS config option.
>>
Besides, you can always disable the driver if you are not interested in
compiling it.
>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/thermal/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 57e06a9..a709c63 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -193,6 +193,7 @@ config X86_PKG_TEMP_THERMAL
>> notification methods.
>>
>> menu "Texas Instruments thermal drivers"
>> +depends on ARCH_OMAP2PLUS
>
> No, this driver is not for ARCH_OMAP*, but for TI bandgap, with the
> option to offer thermal control. So, the HW supported is TI bandgap IP,
> not ARCH_OMAP*. It happens to be so that OMAP2PLUS all have a
> (different) version of this device.
>
> However, DRA7 devices, for instance, also feature the bandgap IP
> (different version of those present in OMAP devices), and it is not
> ARCH_OMAP2PLUS.
>
> And because of that, the design of this driver is different. It is not
> expected to depend on an arch, but the arch code is expected to select
> ARCH_HAS_BANDGAP.
>
>> source "drivers/thermal/ti-soc-thermal/Kconfig"
>> endmenu
>>
>>
>
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
next prev parent reply other threads:[~2013-10-04 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 12:35 [PATCH] thermal: offer TI thermal support only when ARCH_OMAP2PLUS is defined Bartlomiej Zolnierkiewicz
2013-10-04 18:22 ` Eduardo Valentin
2013-10-04 18:26 ` Eduardo Valentin [this message]
2013-10-07 10:05 ` Bartlomiej Zolnierkiewicz
2013-10-07 10:51 ` Bartlomiej Zolnierkiewicz
2013-10-07 9:57 ` Bartlomiej Zolnierkiewicz
2013-10-07 10:50 ` Bartlomiej Zolnierkiewicz
2013-10-07 14:10 ` Bartlomiej Zolnierkiewicz
2013-10-08 14:47 ` Bartlomiej Zolnierkiewicz
2013-10-08 16:09 ` Eduardo Valentin
2013-10-08 16:59 ` Bartlomiej Zolnierkiewicz
2013-10-08 17:40 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524F086E.4020608@ti.com \
--to=eduardo.valentin@ti.com \
--cc=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).