From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: Adrian Huang <adrian.huang@hp.com>,
rjw@rjwysocki.net, viresh.kumar@linaro.org
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linda.knippers@hp.com
Subject: Re: [PATCH 1/1] cpufreq: intel_pstate: skip the driver if ACPI has power mgmt option
Date: Mon, 21 Oct 2013 09:03:07 -0700 [thread overview]
Message-ID: <5265503B.7000804@gmail.com> (raw)
In-Reply-To: <1382333227-28231-1-git-send-email-adrian.huang@hp.com>
On 10/20/2013 10:27 PM, Adrian Huang wrote:
> static int __init intel_pstate_init(void)
> {
> int cpu, rc = 0;
> @@ -708,6 +779,15 @@ static int __init intel_pstate_init(void)
> if (no_load)
> return -ENODEV;
>
> + if (!acpi_disabled) {
> + /*
> + * Check if the platform has its own power management modes.
> + * If so, the pstate cpufreq driver will be ignored.
> + */
> + if (intel_pstate_platform_pwr_mgmt_exists())
> + return 0;
Please return -ENODEV here instead of 0
> + }
> +
> id = x86_match_cpu(intel_pstate_cpu_ids);
> if (!id)
> return -ENODEV;
>
next prev parent reply other threads:[~2013-10-21 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 5:27 [PATCH 1/1] cpufreq: intel_pstate: skip the driver if ACPI has power mgmt option Adrian Huang
2013-10-21 16:03 ` Dirk Brandewie [this message]
2013-10-24 13:23 ` adrian
2013-10-25 22:15 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5265503B.7000804@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=adrian.huang@hp.com \
--cc=cpufreq@vger.kernel.org \
--cc=linda.knippers@hp.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).