From: Laxman Dewangan <ldewangan@nvidia.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Ian Campbell <ian.campbell@citrix.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Thomas Gleixner <tglx@linutronix.de>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Machek <pavel@ucw.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
Date: Wed, 20 Nov 2013 15:24:10 +0530 [thread overview]
Message-ID: <528C86C2.1070206@nvidia.com> (raw)
In-Reply-To: <201311201020.08158.heiko@sntech.de>
On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote:
> Hi,
>
> Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs
> earlier) split the suspend/resume of the irqs into two parts.
>
> The early-irqs get resumed during syscore_resume, while the rest get
> resumed by the regular resume_device_irqs.
>
> I may be blind, but where get the early-irqs resumed in the error
> path of dpm_suspend_noirq?
>
> When a suspend_noirq callback returns an error, dpm_resume_noirq gets called,
> which only calls resume_device_irqs while the suspend_device_irqs call in
> dpm_suspend_noirq suspends all irqs. So it does not seem that the early-irqs
> get resumed at all in this case.
>
I also faced same issue in our suspend failure path and posted fix
sometime ago as
https://lkml.org/lkml/2013/8/13/373
It is still under review.
You can try this patch if it resolve the issue.
Thanks,
Laxman
next prev parent reply other threads:[~2013-11-20 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 9:20 IRQF_RESUME_EARLY and errors in dpm_suspend_noirq Heiko Stübner
2013-11-20 9:54 ` Laxman Dewangan [this message]
2013-11-23 21:25 ` Heiko Stübner
2013-11-24 10:41 ` Pavel Machek
2013-11-24 11:20 ` Pavel Machek
2013-11-25 10:13 ` Ian Campbell
2013-11-25 14:12 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C86C2.1070206@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ian.campbell@citrix.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).